core: cache grpc services #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Closed
stephenplusplus
force-pushed
the
spp--1164
branch
3 times, most recently
from
2f02d70 to
024dd06
Compare
|
@callmehiphop this is safe for review & merge. |
stephenplusplus
force-pushed
the
spp--1164
branch
2 times, most recently
from
07bad7c to
a66d621
Compare
| var service = this.activeServiceMap_.get(serviceMapKey); | ||
|
|
||
| if (!service) { | ||
| service = new proto[protoOpts.service]( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--1164
branch
from
a66d621 to
b623c6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
@murgatroid99 when you have a chance, could you see if this is started off in the right direction? This makes a huge difference in memory usage, but I'm wondering if there are any gotchas I need to be aware of. Thanks!