Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client libraries need out-of-band tests against prereleases of third party dependencies #10578

Closed
tseaver opened this issue Aug 17, 2021 · 3 comments
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Aug 17, 2021

/cc @busunkim96, @tswast, @crwilcox

I had originally worked to add --pre to the testing/constraints-3.9.txt files of the "manual" libraries:

However, in today's meeting the consensus was that such testing needs to happend out-of-band from the normal PR presubmit testing. I have therefore reverted the already-merged PRs which had only that change:

For the already-merged PRs which contained more changes, I have created PRs which back out only the constraint change:

For the not-yet-merged PRs, I have backed out the constraint change, and re-titled them to signal the remaining changes:

Going forward, we need to work out how to do this testing out-of-band.

@tswast
Copy link
Contributor

tswast commented Aug 17, 2021

I've filed googleapis/python-bigquery#882 to add a continuous build for BigQuery.

@busunkim96 busunkim96 added the type: process A process-related concern. May include testing, release, or the like. label Aug 18, 2021
@tswast
Copy link
Contributor

tswast commented Nov 29, 2021

Does --pre in the constraints file do what we want? I'd be more comfortable with that approach if we also had a line to log the version like we have in bigquery. e.g. session.run("python", "-c", "import grpc; print(grpc.__version__)")

Also:

  • There are some packages like pandas and pyarrow which publish their pre-releases to a separate index. These need to be installed separately.
  • We usually specify a top bound to our dependencies, but pre-release versions might be outside those bounds. pip will happily install a non-prerelease version rather than the latest pre-release version to be within those bounds. (We worked around this by using --no-deps in the bigquery session.

@parthea
Copy link
Contributor

parthea commented Jun 10, 2022

Closing as duplicate of googleapis/synthtool#1290

@parthea parthea closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants