tests: allow prerelease deps on Python 3.9 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
|
@tseaver is this just open to run CI or is the goal to merge this in? Is there any concern about getting other prereleases? |
I meant it to be merged, so that we get notified ASAP when a pre-release dependency breaks our tests. |
crwilcox
approved these changes
Aug 11, 2021
This was referenced Aug 17, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
Reverts #415 Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal `presubmit` path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414.