-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different meanings set on values when reading null #1649
Comments
Thanks for the report. This is at the moment a "feature not a bug", though we are certainly open to ideas / discussion. @pcostell WDYT? Also an aside, how does one put a null in a list before |
We managed to get null into lists by saving them from app-engine using python ndb. |
Also, for context, Also original design discussion (go to comment, issue is long). I'm trying to track down the discussion of the decision to use a single type for an entire list, but can't find it. @xamoom-raphael Can you provide a tiny |
Thanks. I'll try to dig into it today (I am running a training so I may not get to it until the evening). |
This was possible in the the private GAE proto for Datastore which stores properties as a repeated proto field. To write a list you just write a property with the same name multiple times and if you don't put any value it is considered null. It seems like we should allow heterogeneous lists to be read since we can store them in Datastore. |
OK I reproduced the example. @pcostell I / we made the decision not to allow heterogeneous meanings since it didn't seem possible within GAE. (We may also require everything in a list to be indexed / not-indexed for the same reason.) It's unclear to me if we should allow null as a special case or if we should just make it a free-for-all. If we did try to do this, it'd be hard to get right:
|
It seems like meanings and indexing information should follow the same On Wed, Mar 23, 2016, 6:05 PM Danny Hermes notifications@github.com wrote:
|
Hey guys, can you give me an update on the issue. |
@dhermes : Update? |
No update right now. This needs a discussion though before we commit to any changes. At a glance, the suggestion from @pcostell of following the same rules as the protos may make it hard to present a higher-level interface to users. |
@dhermes What can we do to make movement here? |
@xamoom-raphael : Just a heads up, the conversation here has gotten a bit theoretical when I think you just want to be able to read your data. Sorry about that. Hang tight while we try to figure something out... If you have any ideas, chime in, but we have to be careful that whatever we do to deal with this situation doesn't give a "false sense of security" or overly complicate things under the hood. I'm joining the bandwagon of "not sure how we could do this in a way that makes sense across the library". Some thoughts...
I can think of a couple different options:
|
The |
Hey,
we have a list in our datastore with ids and sometimes nulls in it. Like here:
When we try to fetch them, we get the "Different meanings set on values within a list_value" Exception.
Is this a bug, that the method does not handles null?
_get_meaning
Method:The text was updated successfully, but these errors were encountered: