Allowing heterogeneous meanings for datastore list properties.

[dhermes]

Fixes #1649.

@pcostell PTAL

[dhermes]

Running my repro snippet after this change verifies that proto -> Entity -> proto doesn't drop any information on the floor.

# python pb_repro.py
e._meanings:
{u'blocks.value': ([None, 15, 15, None], [u'oops', u'foo', u'bar', u'forgot'])}
pb_new == pb:
True

[dhermes]

@tseaver PTAL.

@pcostell Is this good from your end?

[pcostell]

Yup, LGTM

On Fri, Apr 29, 2016 at 10:02 AM Danny Hermes notifications@github.com
wrote:

@tseaver https://github.com/tseaver PTAL.

@pcostell https://github.com/pcostell Is this good from your end?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1758 (comment)

[tseaver]

Given that we've decided to incorporate the notion of heterogenous meanings at all (a feature which seems quite dubious to me), the implementation looks good to merge.

[dhermes]

@tseaver Yes I feel like the meanings code is a very steep uphill climb.