Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore.Entity should not know about the dataset #446

Closed
dhermes opened this issue Dec 19, 2014 · 3 comments
Closed

datastore.Entity should not know about the dataset #446

dhermes opened this issue Dec 19, 2014 · 3 comments
Assignees
@dhermes
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@dhermes
Copy link
Contributor

dhermes commented Dec 19, 2014

This is redundant and potentially problematic.

The Key will know the dataset and that is sufficient.

See #445 and #336 for some context.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 19, 2014
@dhermes
Copy link
Contributor Author

dhermes commented Dec 19, 2014

Ditto for transaction, since it should be implied from the Querys and Keys involved in the transaction.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 19, 2014

More in https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit

@elibixby elibixby mentioned this issue Dec 19, 2014
Closed
@dhermes
Copy link
Contributor Author

dhermes commented Jan 2, 2015

Closing out, this will be covered by #477.

@dhermes dhermes closed this as completed Jan 2, 2015
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
tseaver added a commit that referenced this issue Jun 25, 2018
@tseaver
Add blob properties to support retention policy feature. (#446)
f6048da 
Toward #445.
tseaver added a commit that referenced this issue Aug 28, 2018
@tseaver
Add blob properties to support retention policy feature. (#446)
cee0807 
Toward #445.
tseaver added a commit that referenced this issue Sep 7, 2018
@tseaver
Add blob properties to support retention policy feature. (#446)
c29729e 
Toward #445.
tseaver added a commit that referenced this issue Sep 17, 2018
@tseaver
Add blob properties to support retention policy feature. (#446)
3060050 
Toward #445.
tseaver added a commit that referenced this issue Sep 17, 2018
@tseaver
Add blob properties to support retention policy feature. (#446)
108c557 
Toward #445.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020
atulep pushed a commit that referenced this issue Apr 3, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
bcb9137 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
2047a39 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 6, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
c8444eb 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
atulep pushed a commit that referenced this issue Apr 18, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
7242f36 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
feat(v1): exposed GetProcessorType (#446)
cd82f8d 
* feat: exposed GetProcessorType to v1

PiperOrigin-RevId: 502624243

Source-Link: googleapis/googleapis@bd5f934

Source-Link: googleapis/googleapis-gen@7ae8a3a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2FlOGEzYTk3NTVmNjYxY2U4OTg5ZTlkY2IxNDVkMmRmZjc3ZDg2NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Jun 4, 2023
@msampathkumar @parthea
chore: code clean up for samples are migrated to python-docs-samples (#…
0863fdf 
…446)

* feat: migrate code samples to python-docs-samples

This is a repo-cleanup request.

All manually written code samples are at https://github.com/googleapis/python-dataproc

For more details @ http://b/257073082

* Update and rename CONTRIBUTING.md to README.md

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@release-please
chore(main): release 1.19.1 (#446)
8fc01ae 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Aug 15, 2023
@gcf-owl-bot
ci(python): fix path to requirements.txt in release script (#446)
a6efbfc 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
4caf541 
…v3.11.0 (#446)
parthea added a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
16f4449 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#446)
2d84d38 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(python): add missing import for prerelease testing (#446)
19cc196 
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.3.1 (#446)
98edd08 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472772457

Source-Link: googleapis/googleapis@855b74d

Source-Link: googleapis/googleapis-gen@b64b1e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
parthea added a commit that referenced this issue Oct 21, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#446)
e8b6c6d 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#446)
0bed509 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgeewax @dhermes @yoshi-automation