Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Python 3 support #91

Closed
aliafshar opened this issue May 7, 2014 · 12 comments
Closed

Ensure Python 3 support #91

aliafshar opened this issue May 7, 2014 · 12 comments
Assignees
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aliafshar
Copy link
Contributor

Let's not be that guy.

Though our crypto dependencies might make this non-trivial.

@silvolu silvolu added this to the M1: core, datastore & storage milestone Sep 5, 2014
@dhermes
Copy link
Contributor

dhermes commented Sep 22, 2014

+1

Happy to take the lead on this, e.g. use of six and from __future__ import print_function.

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2014

We need to merge the test coverage stuff first, and then review a bunch of str / unicode stuff.

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2014

Dependency status:

  • httplib2[1] claims Py3K compatibility
  • oauth2client[2] does not document any supported Python versions; its repository CHANGELOG[3] does not list any Py3k compatibility, and it does not install cleanly into a Py33 virtualenv[9]
  • protobuf[4] does not document any supported Python verisions; the changelog for 2.6.0[5] claims "Support for Python 3.", but it doesn't install cleanly into a Py33 virtualenv [10]
  • pycrypto[6] claims Py3K compatibility
  • pyOpenSSL[7] claims Py3K compatibility for 3.2, 3.3
  • pytz[8] claims Py3K compatibility

[1] https://pypi.python.org/pypi/httplib2

[2] https://pypi.python.org/pypi/oauthclient

[3] http://github.com/rca/oauthclient

[4] https://pypi.python.org/pypi/protobuf/2.6.0

[5] http://protobuf.googlecode.com/svn/trunk/CHANGES.txt

[6] https://pypi.python.org/pypi/pycrypto

[7] https://pypi.python.org/pypi/pyOpenSSL

[8] https://pypi.python.org/pypi/pytz

[9] https://gist.github.com/tseaver/aae984fc4720ed29e573

[10] https://gist.github.com/tseaver/0531a23cf6ca58fefcea

@dhermes
Copy link
Contributor

dhermes commented Sep 22, 2014

It's also worth mentioning that protobuf currently won't install:

The following work-around is required:

$ # Downgrade to fool protobuf: Requirement.parse('python-dateutil>=1.4,<2').
$ sudo pip install -U python-dateutil==1.5
$ # Install with downgraded python-dateutil.
$ sudo pip install protobuf
$ # Upgrade back to newest version of python-dateutil.
$ sudo pip install -U python-dateutil

UPDATE (on 11/2/2014): This was resolved a few weeks ago.

@dhermes
Copy link
Contributor

dhermes commented Nov 5, 2014

UPDATE: oauth2client supports Py3

@tseaver tseaver self-assigned this Nov 13, 2014
@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2014

I'm working today on a branch which uses modernize to fix up bits in the code which will be problematic under Py3k.

@dhermes
Copy link
Contributor

dhermes commented Nov 13, 2014

Awesome! protobuf is our only dep which is not over the line yet? Do we have a tracking bug (like protocolbuffers/protobuf#36) in place?

UPDATE:
protocolbuffers/protobuf#7
protocolbuffers/protobuf#9

@tseaver
Copy link
Contributor

tseaver commented Nov 24, 2014

I've done some review on google/protobuf/#66: it appears the maintainers believe that preserving 2.5 compatibility is more important than adding 3.x compatibility cleanly.

If we go ahead with #334, we need to solve the problem of Python3 compatibility for /craigcitro/apitools, and its dependencies too. The most problematic one remaining is google-protorpc -- see #60 there, as well as my modernize-prep-py3k branch. Craig is not sanguine about getting even the smaller changeset to land in the internal repo.

@tseaver
Copy link
Contributor

tseaver commented Feb 9, 2015

Assuming we go forward with requiring protobuf 3.0.0-alpha-1 or later, we have already merged our own changes to support Python 3.3 / 3.4, but are blocked on officially supporting them by googleapis/oauth2client#125 (fix merged but not yet released).

@tseaver
Copy link
Contributor

tseaver commented Feb 24, 2015

#676 changes the regression3 environment to use a checkout of oauth2client until a release is available which fixes googleapis/oauth2client#125

@dhermes
Copy link
Contributor

dhermes commented Apr 13, 2015

Wooooooo! Closed by #820

@dhermes dhermes closed this as completed Apr 13, 2015
@dhermes
Copy link
Contributor

dhermes commented Apr 13, 2015

As for concerns about readiness of protobuf 3.0.0-alpha-1, see protocolbuffers/protobuf#250

urshala pushed a commit to urshala/google-cloud-python that referenced this issue Jan 17, 2020
Sorry for the delay on merging this. I thought I had posted a comment but it turns out I hadn't.
atulep pushed a commit that referenced this issue Apr 6, 2023
Make samples kokoro sessions required
atulep pushed a commit that referenced this issue Apr 18, 2023
Make samples kokoro sessions required
parthea pushed a commit that referenced this issue May 31, 2023
- [ ] Regenerate this pull request now.

fix: improper types in pagers generation
PiperOrigin-RevId: 399773015

Source-Link: googleapis/googleapis@410c184

Source-Link: googleapis/googleapis-gen@290e883
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9
parthea pushed a commit that referenced this issue Jun 4, 2023
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
* chore: use gapic-generator-python 1.0.0

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
* chore: Update gapic-generator-python to v1.9.0

PiperOrigin-RevId: 517425588

Source-Link: googleapis/googleapis@33c93eb

Source-Link: googleapis/googleapis-gen@d5f5978
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDVmNTk3ODlkMTlmYzQzMjcwZmYyMTI0OTY3ZDRlYzg5OTJiOGU4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Sep 14, 2023
parthea added a commit that referenced this issue Sep 20, 2023
fix(deps): require proto-plus >= 1.22.0
parthea added a commit that referenced this issue Sep 20, 2023
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0

* fix(deps): require google-api-core>=1.33.2
parthea pushed a commit that referenced this issue Sep 22, 2023
fix: disable always_use_jwt_access

Committer: @busunkim96
PiperOrigin-RevId: 382142900

Source-Link: googleapis/googleapis@513440f

Source-Link: googleapis/googleapis-gen@7b1e2c3
parthea pushed a commit that referenced this issue Sep 22, 2023
The samples tests create `.nox` directories
with all dependencies installed. These directories
should be excluded from linting.

I've tested this change locally, and it significantly
speeds up linting on my machine.

Source-Author: Tim Swast <swast@google.com>
Source-Date: Tue Dec 22 13:04:04 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 373861061648b5fe5e0ac4f8a38b32d639ee93e4
Source-Link: googleapis/synthtool@3738610
parthea pushed a commit that referenced this issue Sep 22, 2023
This reverts commit 1d32d3c81f70350cae828543c0b5a09ee9c477b7.
parthea pushed a commit that referenced this issue Sep 22, 2023
chore: add SECURITY.md
parthea pushed a commit that referenced this issue Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa
parthea pushed a commit that referenced this issue Sep 22, 2023
* chore: another flaky test for video beta samples

* changed it to timeout
parthea added a commit that referenced this issue Oct 21, 2023
* chore: update to gapic-generator-python 1.5.0

feat: add support for `google.cloud.<api>.__version__`
PiperOrigin-RevId: 484665853

Source-Link: googleapis/googleapis@8eb249a

Source-Link: googleapis/googleapis-gen@c8aa327
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update version in gapic_version.py

* feat: new APIs added to reflect updates to the filestore service

- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled

PiperOrigin-RevId: 487492758

Source-Link: googleapis/googleapis@5be5981

Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.6.1

PiperOrigin-RevId: 488036204

Source-Link: googleapis/googleapis@08f275f

Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* use autogenerated setup.py

* run nox format session

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
Source-Link: googleapis/synthtool@993985f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd
parthea pushed a commit that referenced this issue Oct 21, 2023
…91)

Source-Link: googleapis/synthtool@95d9289
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
parthea pushed a commit that referenced this issue Oct 21, 2023
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-analytics-admin](https://togithub.com/googleapis/python-analytics-admin) | `==0.3.2` -> `==0.4.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-analytics-admin/0.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-analytics-admin/0.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-analytics-admin/0.4.0/compatibility-slim/0.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-analytics-admin/0.4.0/confidence-slim/0.3.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-analytics-admin</summary>

### [`v0.4.0`](https://togithub.com/googleapis/python-analytics-admin/blob/master/CHANGELOG.md#&#8203;040-httpswwwgithubcomgoogleapispython-analytics-admincomparev032v040-2021-06-23)

[Compare Source](https://togithub.com/googleapis/python-analytics-admin/compare/v0.3.2...v0.4.0)

##### Features

-   add always_use_jwt_access ([#&#8203;89](https://www.github.com/googleapis/python-analytics-admin/issues/89)) ([268fdec](https://www.github.com/googleapis/python-analytics-admin/commit/268fdec4dd859a42d1025f94812053311df149ce))

##### Documentation

-   omit mention of Python 2.7 in 'CONTRIBUTING.rst' ([#&#8203;1127](https://www.github.com/googleapis/python-analytics-admin/issues/1127)) ([#&#8203;84](https://www.github.com/googleapis/python-analytics-admin/issues/84)) ([6ce863e](https://www.github.com/googleapis/python-analytics-admin/commit/6ce863e147dae3c1da40c27034a0ac42180c6303)), closes [#&#8203;1126](https://www.github.com/googleapis/python-analytics-admin/issues/1126)

##### [0.3.2](https://www.github.com/googleapis/python-analytics-admin/compare/v0.3.1...v0.3.2) (2021-06-16)

##### Bug Fixes

-   **deps:** add packaging requirement ([#&#8203;80](https://www.github.com/googleapis/python-analytics-admin/issues/80)) ([6d99bcc](https://www.github.com/googleapis/python-analytics-admin/commit/6d99bcc3e940e4f6bc857e7d4ede53e01537c7ec))

##### [0.3.1](https://www.github.com/googleapis/python-analytics-admin/compare/v0.3.0...v0.3.1) (2021-06-16)

##### Bug Fixes

-   exclude docs and tests from package ([#&#8203;78](https://www.github.com/googleapis/python-analytics-admin/issues/78)) ([680a695](https://www.github.com/googleapis/python-analytics-admin/commit/680a695e446c979e30542cd4dc563028b126aef5))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-analytics-admin).
parthea pushed a commit that referenced this issue Oct 21, 2023
Source-Link: googleapis/synthtool@b0eb8a8
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
parthea pushed a commit that referenced this issue Oct 21, 2023
- [ ] Regenerate this pull request now.

docs: list oneofs in docstring
fix(deps): require google-api-core >= 1.28.0
fix(deps): drop packaging dependency

committer: busunkim96@
PiperOrigin-RevId: 406468269

Source-Link: googleapis/googleapis@83d81b0

Source-Link: googleapis/googleapis-gen@2ff001f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9
parthea pushed a commit that referenced this issue Oct 21, 2023
chore: add SECURITY.md
parthea pushed a commit that referenced this issue Oct 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this issue Oct 22, 2023
* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python

PiperOrigin-RevId: 423842556

Source-Link: googleapis/googleapis@a616ca0

Source-Link: googleapis/googleapis-gen@29b938c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
Make samples kokoro sessions required
parthea pushed a commit that referenced this issue Oct 22, 2023
Source-Link: googleapis/synthtool@b91f129
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:b6169fc6a5207b11800a7c002d0c5c2bc6d82697185ca12e666f44031468cfcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants