Prepare for py3k #374

tseaver · 2014-11-13T19:43:13Z

Make a start toward #91 (we are still blocked on the protobuf dependency).

Selectively apply patches suggested by 'python-modernize --six-unicode'.

Tweak the pylint messages suppressed in test/demo code to work around issues involved in "straddling" Python2/Python3:

The six module does some import hackery which confuses pylint when used in a virtualenv: suppress import-error check (only in test/demo code). Note that the check is redundant (we have 100% coverage) as well as failing bogusly.
Rather than introduce from __future__ import print_statement in demos, just use print(), which is legal in Python2, and forward-compatible to Python3, but causes a `superfluous-parens' warning under pylint: suppress that warning (only test/demo code).

The 'six.moves' module (used in demo code) is known to confuse pylint when used in conjunction with virtualenv. See: https://bitbucket.org/logilab/pylint/issue/73/pylint-is-unable-to-import

The error trips over using 'print(thing)' in Python2, which is legal, and forward-compatible to Py3k for simple cases. Rather than introduce the 'from __future__ import print_function' into the demo, just suppress the warning.

coveralls · 2014-11-13T19:52:55Z

Coverage remained the same when pulling e544d27 on tseaver:modernize-prep_for_py3k into 9d6efcf on GoogleCloudPlatform:master.

gcloud/datastore/demo/demo.py

@@ -16,47 +16,47 @@
 toy.save()

 # If we look it up by its key, we should find it...
-print dataset.get_entities([toy.key()])
+print(dataset.get_entities([toy.key()]))


We were getting it transitively, but better to say we need it.

They were wrongly introduced by .

coveralls · 2014-11-15T19:32:22Z

Coverage remained the same when pulling 92beb55 on tseaver:modernize-prep_for_py3k into 9d6efcf on GoogleCloudPlatform:master.

coveralls · 2014-11-15T19:41:23Z

Coverage remained the same when pulling 7706cd9 on tseaver:modernize-prep_for_py3k into 9d6efcf on GoogleCloudPlatform:master.

dhermes · 2014-11-16T21:38:05Z

All seems well except possible resolving the use of six.u, which can be done outside of this PR. Let's resolve (the decision) before I LGTM. We should run by @silvolu about explicitly not supporting 2.5 and / or 3.2.

Are we ready to add a py34 environ to tox? Do you want to do it in this PR or catch it in another cycle?

tseaver · 2014-11-16T23:03:03Z

WRT 3.2: FWIW, 3.2 is the "system python3" version for Ubuntu 12.04 ("precise") and Debian stable ("wheezy"). Dropping support for 3.2 would make the six.u() ugliness go away.

WRT 2.5: Given that current travis / tox / virtualenv / pip / setuptools don't support Python 2.5, and that we therefore cannot automate testing for it, I recommend that we drop support, as recommended in Lennart Regebro's excellent book on porting to Python3.

WRT tox -e py34: We can't add 'py3x' until we get the transitive closure of our dependencies cleanly installable in Python 3 (google-apputils is the current crtiical path blocker).

dhermes · 2014-11-17T05:25:02Z

RE: 3.2 on an LTS release, eek! This makes me sad, the EOL is still May 2017 so I'm not as confident as I previously was. If we use the from __future__ import unicode_literals import this will not be an issue, thought that import does not exist in 2.5.

tseaver · 2014-11-24T19:34:33Z

from future __import_literals__ is problematic if we care at all about being able to test with "native" strings on Python2. I'd rather drop 3.2 support than use it.

Since we have decided not to support Python 3.2.x, we can avoid the wart.

coveralls · 2014-11-24T22:01:03Z

Coverage remained the same when pulling 38f7425 on tseaver:modernize-prep_for_py3k into 9d6efcf on GoogleCloudPlatform:master.

tseaver · 2014-11-24T22:07:10Z

@dhermes six.u replaced by unicode literals in 38f7425.

regression/clear_datastore.py

@@ -1,9 +1,11 @@
 """Script to populate datastore with regression test data."""
+from __future__ import print_function


dhermes · 2014-11-24T22:13:07Z

LGTM pending your decision on the two imports of print_function in the regression directory.

Can we update #91 with what remains?

@dhermes

Incorporates feedback from @dhermes: #374 (comment) #374 (comment)

coveralls · 2014-11-24T22:25:08Z

Coverage remained the same when pulling dfa70b5 on tseaver:modernize-prep_for_py3k into 9d6efcf on GoogleCloudPlatform:master.

tseaver · 2014-11-24T22:25:11Z

Re: updating #91: #91 (comment)

Prepare for py3k

* feat: support async write mode for WriteUserEvent API feat: support collect and import GA4 event format with prebuilt whistle rule feat: support exact searchable and retrievable in catalog attribute config feat: deprecate retrievable_fields in product attribute feat: support diversity type in serving config feat: allow set feed id in merchant center link feat: support data output to GCS docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 495893148 Source-Link: googleapis/googleapis@02dcec3 Source-Link: googleapis/googleapis-gen@996aa46 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTk2YWE0NmZlNDgyZWY4MDdhMzNiNTZkMTViMjhhZDU1ZmJhYzdiOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix flaky test * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc

* chore: use gapic-generator-python 0.65.1 PiperOrigin-RevId: 441524537 Source-Link: googleapis/googleapis@2a27391 Source-Link: googleapis/googleapis-gen@ab6756a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added 4 commits November 13, 2014 14:33

Sort disabled messages for test/demo code.

d3388c8

Disable 'import-error' for test/demo code.

f4e4a0d

The 'six.moves' module (used in demo code) is known to confuse pylint when used in conjunction with virtualenv. See: https://bitbucket.org/logilab/pylint/issue/73/pylint-is-unable-to-import

Disable 'superfluous-parens' for demo code.

7f2d6e1

The error trips over using 'print(thing)' in Python2, which is legal, and forward-compatible to Py3k for simple cases. Rather than introduce the 'from __future__ import print_function' into the demo, just suppress the warning.

Selectively apply patches suggested by 'python-modernize --six-unicode'.

e544d27

tseaver added the milestone-feature label Nov 13, 2014

dhermes reviewed Nov 15, 2014
View reviewed changes

tseaver added 5 commits November 15, 2014 14:09

PEP8.

b79e1bc

Explicitly declare dep. on 'six'.

0f44997

We were getting it transitively, but better to say we need it.

PEP8.

98a9960

Remove spurious 'list(foo.items())' wrappers.

790f649

They were wrongly introduced by .

No need for 'try: ... except:' when we have 'six'.

92beb55

Moar no need for 'try: ... except:' when we have 'six'.

7706cd9

Restore unicode literals.

38f7425

Since we have decided not to support Python 3.2.x, we can avoid the wart.

dhermes reviewed Nov 24, 2014
View reviewed changes

regression/clear_datastore.py

@@ -1,9 +1,11 @@

"""Script to populate datastore with regression test data."""

from __future__ import print_function

This comment was marked as spam.

Sign in to view

Drop future import where we don't use its features.

dfa70b5

Incorporates feedback from @dhermes: #374 (comment) #374 (comment)

tseaver added a commit that referenced this pull request Nov 24, 2014

Merge pull request #374 from tseaver/modernize-prep_for_py3k

655191e

Prepare for py3k

tseaver merged commit 655191e into googleapis:master Nov 24, 2014

tseaver deleted the modernize-prep_for_py3k branch November 24, 2014 22:26

dhermes added the hygiene label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-speech to v2.14.0 (#374)

3bac8e8

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(deps): update dependency google-cloud-speech to v2.14.0 (#374)

d673a5f

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(deps): update dependency google-cloud-speech to v2.14.0 (#374)

fa2979e

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.1.3 (#374)

36e51c9

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(deps): update dependency google-auth to v2.11.1 (#374)

3f21f8b

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-pubsub to v2.13.5 (#374)

fe303fa

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency backoff to v2.2.1 (#374)

e75a30a

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.8.0 (#374)

5db9198

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-admin to v0.20.0 (#374)

2256ec7

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency google-cloud-speech to v2.14.0 (#374)

b640ebc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for py3k #374

Prepare for py3k #374

tseaver commented Nov 13, 2014

coveralls commented Nov 13, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 15, 2014

coveralls commented Nov 15, 2014

dhermes commented Nov 16, 2014

tseaver commented Nov 16, 2014

dhermes commented Nov 17, 2014

tseaver commented Nov 24, 2014

coveralls commented Nov 24, 2014

tseaver commented Nov 24, 2014

This comment was marked as spam.

dhermes commented Nov 24, 2014

coveralls commented Nov 24, 2014

tseaver commented Nov 24, 2014

		@@ -1,9 +1,11 @@
		"""Script to populate datastore with regression test data."""
		from __future__ import print_function

Prepare for py3k #374

Prepare for py3k #374

Conversation

tseaver commented Nov 13, 2014

coveralls commented Nov 13, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 15, 2014

coveralls commented Nov 15, 2014

dhermes commented Nov 16, 2014

tseaver commented Nov 16, 2014

dhermes commented Nov 17, 2014

tseaver commented Nov 24, 2014

coveralls commented Nov 24, 2014

tseaver commented Nov 24, 2014

This comment was marked as spam.

dhermes commented Nov 24, 2014

coveralls commented Nov 24, 2014

tseaver commented Nov 24, 2014