chore(migration): Migrate code from googleapis/python-access-context-manager into packages/google-cloud-access-context-manager #13425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/008ce5bf-87d6-4df6-a516-9e6d6ecebea4/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@41a4e56 Source-Link: googleapis/synthtool@f15b57c
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9d4e6069-5c18-4f79-97fb-99ebae377691/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@4679e7e Source-Link: googleapis/synthtool@3336657 Source-Link: googleapis/synthtool@d1bb917 Source-Link: googleapis/synthtool@573f765 Source-Link: googleapis/synthtool@ba960d7 Source-Link: googleapis/synthtool@16ec872 Source-Link: googleapis/synthtool@fb53b6f
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Feb 17 14:10:46 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: d17674372e27fb8f23013935e794aa37502071aa Source-Link: googleapis/synthtool@d176743
Uncomment `generate_protos` and clone `api-common-protos` inside the session so it can be run in autosynth. Fixes #27 🦕 Verify locally by doing `nox -s generate_protos` (no additional setup should be required)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: prevent normalization of semver versioning * chore: update workaround to make sic work
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/860fdaa7-9560-4476-817f-d4f818ae9a94/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@043cc62 Source-Link: googleapis/synthtool@721339a Source-Link: googleapis/synthtool@0a071b3 Source-Link: googleapis/synthtool@5b5bf6d
Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0856ca711da1fd5ec9d6d7da6c50aa0bbf550fb94acb47b55159a640791987bf
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:c66ba3c8d7bc8566f47df841f98cd0097b28fff0b1864c86f5817f4c8c3e8600
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@71a7297 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: remove pb2 file generation during post processing step * chore: remove obsolete proto files
* chore: remove pb2 file generation during post processing step * chore: remove obsolete proto files * chore: add generation of pb2 files via owlbot/bazel
…-manager/main' into migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…-01-10.16-06-17.migrate' of https://github.com/googleapis/google-cloud-python into migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
vchudnov-g
approved these changes
Jan 10, 2025
| "library_type": "GAPIC_AUTO", | ||
| "repo": "googleapis/google-cloud-python", | ||
| "distribution_name": "google-cloud-access-context-manager", | ||
| "default_version": "apiVersion", |
There was a problem hiding this comment.
apiVersion is a replacement string, right? At what point does that get replaced with the right version?
| google.identity.accesscontextmanager.type | ||
| ========================================= | ||
|
|
||
| .. automodule:: google.identity.accesscontextmanager.type |
There was a problem hiding this comment.
A bunch of these type.rst files used to have these lines ending in ….type.XXXX_pb2, but now they're truncated to end in ….type. I take it this is expected?
There was a problem hiding this comment.
Yes. This is intended. For now the docs for pb2.py files are not meaningful at the moment. We may use pb2.pyi files instead for docs. b/375167345 is the tracking bug to improve docs in pb2.pyi. The protobuf team has indicated that docs (comments) won't be added to pb2.py files.
parthea
deleted the
migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate
branch
parthea
added a commit
that referenced
this pull request
Jan 16, 2025
…config action (#13436) The Github Action that updates the [release please configuration](https://github.com/googleapis/google-cloud-python/blob/main/.github/workflows/configure_release_please.yml) recently started failing after PRs #13425, #13426 and #13427 were merged. The reason is that the action expects packages to have a file called `gapic_version.py`, however these packages do not. This PR updates the release please configuration script to exclude packages which do not have this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10887.
This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.