-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(migration): Migrate code from googleapis/python-audit-log into packages/google-cloud-audit-log #13426
chore(migration): Migrate code from googleapis/python-audit-log into packages/google-cloud-audit-log #13426
Conversation
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/1b172ea4-6e2b-49f2-b1b9-cadea69c5d6e/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5dfda56
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d5a3b809-9df8-4d37-93b2-9714b500d6ce/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bfcdbe0
Co-authored-by: Tim Swast <swast@google.com> Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Thu Jan 7 13:05:12 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 41a4e56982620d3edcf110d76f4fcdfdec471ac8 Source-Link: googleapis/synthtool@41a4e56
This is the sibling PR to GoogleCloudPlatform/python-docs-samples#5611 and this is the issue opened for it GoogleCloudPlatform/python-docs-samples#5549
Migrate python libraries onto the PyPI API token stored in secret manager. A PyPI API token is limited in scope to uploading new releases. https://pypi.org/help/#apitoken Verified that this works with [build](https://fusion2.corp.google.com/invocations/14bae126-83fa-4328-8da9-d390ed99315c/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-vision%2Frelease%2Frelease;config=default/log) on googleapis/python-vision#136 Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Apr 14 17:46:06 2021 -0600 Source-Repo: googleapis/synthtool Source-Sha: 043cc620d6a6111816d9e09f2a97208565fde958 Source-Link: googleapis/synthtool@043cc62
* chore: prevent normalization of semver versioning * chore: update workaround to make sic work
chore: add SECURITY.md
* chore: add library type to .repo-metadata.json * set library type to "OTHER" in .repo-metadata.json
Source-Link: googleapis/synthtool@b0eb8a8 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
Source-Link: googleapis/synthtool@53ea389 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:e1793a23ae0ee9aafb2e3a53b564a351f74790dbe3c2d75f8fc3b8c43e5c036c
Source-Link: googleapis/synthtool@e44dc0c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d
Source-Link: googleapis/synthtool@dd05f9d Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:aea14a583128771ae8aefa364e1652f3c56070168ef31beb203534222d842b8b
* fix: remove deprecated call to Descriptor(). Fixes #14.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chore: removing owlbot directives for conversion to main
chore: relocate owl bot post processor
* chore: update templated files * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@e808c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: remove pb2 file generation during post processing step * chore: remove obsolete proto files
* chore: remove pb2 file generation during post processing step * chore: remove obsolete proto files * chore: add generation of pb2 files via owlbot/bazel
…' into migration.python-audit-log.repo.stats.2025-01-10.16-06-17.migrate
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…17.migrate' of https://github.com/googleapis/google-cloud-python into migration.python-audit-log.repo.stats.2025-01-10.16-06-17.migrate
:target: https://pypi.org/project/google-cloud-audit-log/ | ||
.. _Audit Log: https://github.com/googleapis/googleapis/tree/master/google | ||
.. _Client Library Documentation: https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-audit-log/summary_overview | ||
.. _Product Documentation: https://github.com/googleapis/googleapis/tree/master/google |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect. Should we point to the proto directory for this api withing googleapis/googleapis
? Or better yet, the actual product page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8995f51
{ | ||
"name": "auditlog", | ||
"name_pretty": "Audit Log", | ||
"product_documentation": "https://github.com/googleapis/googleapis/tree/master/google", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect (not specific enough at the very least, but ideally we should point to the actual product page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8995f51
|
||
.. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||
.. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project | ||
.. _Enable the Audit Log.: https://github.com/googleapis/googleapis/tree/master/google |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not useful. We should point to specific instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…config action (#13436) The Github Action that updates the [release please configuration](https://github.com/googleapis/google-cloud-python/blob/main/.github/workflows/configure_release_please.yml) recently started failing after PRs #13425, #13426 and #13427 were merged. The reason is that the action expects packages to have a file called `gapic_version.py`, however these packages do not. This PR updates the release please configuration script to exclude packages which do not have this file.
See #11200.
This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.