chore(librarian): fix remove_regex for googleapis-common-protos #14850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
approved these changes
Nov 5, 2025
parthea
added a commit
that referenced
this pull request
Nov 5, 2025
This PR depends on #14850 `google/cloud` was not listed as an api path for `googleapis-common-protos` for code was not being generated for https://github.com/googleapis/googleapis/blob/master/google/cloud/extended_operations.proto and https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto
parthea
added a commit
that referenced
this pull request
Nov 5, 2025
The commit body is not needed when creating release notes. It was originally added to workaround googleapis/librarian#2234. As per googleapis/librarian#2234 (comment), we should not include the body in the release notes. Without the fix in this PR, the changelog for `googleapis-common-protos` looks like this ``` ## [1.72.0](googleapis-common-protos-v1.71.0...googleapis-common-protos-v1.72.0) (2025-11-05) ### Features * add common_resources.proto (#14851) This PR depends on #14850 `google/cloud` was not listed as an api path for `googleapis-common-protos` for code was not being generated for https://github.com/googleapis/googleapis/blob/master/google/cloud/extended_operations.proto and https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto ([e4e0e2a](e4e0e2a)) * add field api_version to message ServiceForTransport (#14843) This PR was created locally. The reason that this could not be automated is that the current directory structure [gapic/metadata](https://github.com/googleapis/googleapis/tree/master/gapic/metadata) doesn't align with the protobuf package name [google.gapic.metadata](https://github.com/googleapis/googleapis/blob/53af3b727f84acc34e31c23f3b6e7b8aa4b7e837/gapic/metadata/gapic_metadata.proto#L18). The expected directory structure for `google.gapic.metadata` is `google/gapic/metadata`. In the `googleapis-common-protos` package, the `gencode` is in the expected location ([81812fd](81812fd)) ``` With the fix, the changelog for `googleapis-common-protos` looks like this ``` ## [1.72.0](googleapis-common-protos-v1.71.0...googleapis-common-protos-v1.72.0) (2025-11-05) ### Features * add common_resources.proto (#14851) ([e4e0e2a](e4e0e2a)) * add field api_version to message ServiceForTransport (#14843) ([81812fd](81812fd)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following issues when running
librarian generateforgoogleapis-common-protos..repo-metadata.jsonis included in the generated outputREADME.rstis included in the generated outputdocs/summary_overview.mdis included in the generated outputgoogle/loggingwhich was missedThis also uncovered an issue where we were not generating code for https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto. I'll address this in a separate PR