Preparing PyLint for subpackage breakup. #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
updating-pylint-for-subpackages
branch
from
cb9317d to
18e1785
Compare
dhermes
commented
Sep 22, 2016
| parser = get_parser() | ||
| args = parser.parse_args() | ||
| main(build_root=args.build_root) | ||
| verify_modules(build_root=args.build_root) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Sep 22, 2016
| parser = get_parser() | ||
| args = parser.parse_args() | ||
| main(build_root=args.build_root) | ||
| verify_modules(build_root=args.build_root) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The docstrings don't get included in the module objects so there is no reason to have them.
|
@tseaver Sorry I just realized I left out the important part: Taking the docstrings out of namespace package |
|
@tseaver LMK if the 2nd commit was problematic. |
|
@dhermes Nope. |
This was referenced Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change started out in #2367 but I figured we'd get it out of the way here since it's not as much in dispute.