Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system tests for legacy data types. #3116

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Add system tests for legacy data types. #3116

merged 1 commit into from
Mar 8, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 7, 2017

Toward #3029.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. testing labels Mar 7, 2017
@tseaver tseaver requested review from daspecster and dhermes March 7, 2017 21:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2017
@tseaver tseaver mentioned this pull request Mar 7, 2017
Closed
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 7, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Mar 7, 2017

Hold off on review: the use_legacy_sql flag is set incorrectly.

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 7, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Mar 7, 2017

OK, I've pushed a version which flips the flag and drops the couldn't-possibly-work standard-SQL-only examples.

dhermes
dhermes reviewed Mar 7, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good

system_tests/bigquery.py
@@ -479,6 +479,63 @@ def _job_done(instance):
# raise an error, and that the job completed (in the `retry()`
# above).

def test_sync_query_w_legacy_sql_types(self):
import datetime

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

system_tests/bigquery.py Outdated
from google.cloud.bigquery._helpers import ScalarQueryParameter
from google.cloud.bigquery._helpers import StructQueryParameter
naive = datetime.datetime(2016, 12, 5, 12, 41, 9)
stamp = "%s %s" % (naive.date().isoformat(), naive.time().isoformat())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

system_tests/bigquery.py Outdated
for example in EXAMPLES:
query = Config.CLIENT.run_sync_query(
example['sql'],
query_parameters=example.get('query_parameters', ()))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 7, 2017

LGTM, but ping me once CI is green so I can do a final pass?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2017

@dhermes CI is green.

@tseaver tseaver merged commit 8b39bb0 into googleapis:master Mar 8, 2017
@tseaver tseaver deleted the 3029-bigquery-systest-legacy_datatypes branch March 8, 2017 04:16
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#3116 from tseaver/3029-bigquery-systest…
de2f9e9 
…-legacy_datatypes

Add system tests for legacy data types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@daspecster daspecster Awaiting requested review from daspecster

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot