Spanner: Range single keys index #4416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
spanner_range_single_keys_index
branch
from
a754bd7 to
317fbcc
Compare
chemelnucfin
changed the title
tseaver
reviewed
Dec 4, 2017
spanner/tests/system/test_system.py
Outdated
| ) | ||
| selected = ([expected[keyrow]] + | ||
| expected[indices[index][0]:indices[index][1]]) | ||
| self.assertEqual(rows, selected) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
19 tasks
chemelnucfin
force-pushed
the
spanner_range_single_keys_index
branch
from
317fbcc to
d0078d1
Compare
Contributor
Author
|
@tseaver PTAL, thanks. |
tseaver
suggested changes
Dec 5, 2017
spanner/tests/system/test_system.py
Outdated
| columns = self.COLUMNS[1], self.COLUMNS[2] | ||
| session, committed = self._set_up_table(row_count) | ||
| self.to_delete.append(session) | ||
| expected = [[row[1], row[2]] for row in self._row_data(row_count)] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
spanner/tests/system/test_system.py
Outdated
| expected = [[row[1], row[2]] for row in self._row_data(row_count)] | ||
| keyrow, start, end = 1, 3, 7 | ||
| start_index = [expected[start][0], expected[start][1]] | ||
| end_index = [expected[end][0], expected[end][1]] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
spanner/tests/system/test_system.py
Outdated
| keyset, | ||
| index='name') | ||
| ) | ||
| selected = ([expected[keyrow]] + expected[start : end+1]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chemelnucfin
force-pushed
the
spanner_range_single_keys_index
branch
2 times, most recently
from
7a38834 to
7c24064
Compare
tseaver
reviewed
Dec 6, 2017
spanner/tests/system/test_system.py
Outdated
| keyrow, start, end = 1, 3, 7 | ||
| closed_closed = KeyRange(start_closed=expected[start], | ||
| end_closed=expected[end]) | ||
| keys = [expected[keyrow],] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Dec 13, 2017
chemelnucfin
force-pushed
the
spanner_range_single_keys_index
branch
from
1b17bce to
1eb298a
Compare
Contributor
Author
|
I added "and" in the title to separate from another set of tests. Merging on green. |
chemelnucfin
force-pushed
the
spanner_range_single_keys_index
branch
from
1eb298a to
ed567d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm separating the tests into different PRs to minimize the damage. I plan to do the refactor once all the tests are all in and I'll do it separately so I don't change too much code at once.