Skip to content

Conversation

@chemelnucfin
Copy link
Contributor

@chemelnucfin chemelnucfin commented Dec 11, 2017

Merge #4416 first

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2017
@chemelnucfin chemelnucfin force-pushed the spanner_multiple_ranges_single_key branch from e0c2afa to b7e385f Compare December 11, 2017 21:29
@chemelnucfin chemelnucfin changed the title Spanner multiple ranges single key Spanner: multiple ranges single key Dec 12, 2017
@chemelnucfin chemelnucfin force-pushed the spanner_multiple_ranges_single_key branch from b7e385f to 696a0f2 Compare December 13, 2017 19:40
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than my nit

krange = KeyRange(start_closed=data[start], end_open=data[start + 1])
keyset = KeySet(ranges=(krange,))
rows = list(session.read(self.TABLE, columns, keyset, index='name'))
self.assertEqual(rows, data[start : start+1])

This comment was marked as spam.

This comment was marked as spam.

@chemelnucfin chemelnucfin merged commit 67453b5 into googleapis:master Dec 18, 2017
@tseaver tseaver mentioned this pull request Dec 19, 2017
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants