Spanner: Range read with single key #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
reviewed
Dec 11, 2017
spanner/tests/system/test_system.py
Outdated
| snapshot = session.snapshot(read_timestamp=committed, multi_use=True) | ||
| all_data_rows = list(self._row_data(ROW_COUNT)) | ||
|
|
||
| single_key = KeyRange(start_closed=[START], end_open=[START+1]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chemelnucfin
force-pushed
the
spanner_range_single_key
branch
from
2267fb6 to
6671ac2
Compare
dhermes
approved these changes
Dec 18, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM other than my nit.
It seems you might want to put the newly added case in a separate method on the unittest.TestCase subclass, but it sort of belongs where you put it, so I don't feel strongly.
| rows = list(snapshot.read( | ||
| self.TABLE, self.COLUMNS, keyset)) | ||
| expected = all_data_rows[START:END+1] | ||
| expected = all_data_rows[START : END+1] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.