Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

477: Prepare to remove dataset #499

Closed
wants to merge 9 commits into from
Closed

477: Prepare to remove dataset #499

wants to merge 9 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 7, 2015

  • Don't document use of 'Dataset' or its factory methods.
  • Ensure that we have an implicit dataset ID.
  • Ensure that Key.__init__ uses implicit dataset ID when appropriate.

Toward #477, step 8.

@tseaver tseaver changed the title 477 prepare to remove dataset 477: Prepare to remove dataset Jan 7, 2015
@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

@tseaver I'm also working on this (I am the assignee on #477, sorry for not communicating that I was working on it)

dhermes
dhermes reviewed Jan 7, 2015
View reviewed changes
gcloud/datastore/key.py
@@ -384,3 +369,24 @@ def parent(self):

def __repr__(self):
return '<Key%s, dataset=%s>' % (self.path, self.dataset_id)

def _validate_dataset_id(dataset_id, parent):

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Jan 7, 2015
Merged
tseaver added 5 commits January 7, 2015 14:30
@tseaver
Overlooked coverage foul.
99af098
@tseaver
Remove dead fixture.
57e179b
@tseaver
Rework '_require_dataset' -> '_require_dataset_id'.
ad78f59 
Also, make both it and '_require_connection' take the passed object,
and test explicitly against None.
@tseaver
Add 'set_default_dataset_id' helper.
ce5a207 
Will replace 'set_default_dataset'.
@tseaver
Valet service.
8baf341
@tseaver
Copy link
Contributor Author

tseaver commented Jan 7, 2015

Sorry for the clash: I was trying to nibble at the edges to remove more usage of Dataset before we actually removed the module.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

No worries. What do you want to do? RE: #500

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8baf341 on tseaver:477-prepare_to_remove_dataset into f176098 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Jan 7, 2015

Why don't we go ahead with #500: we can eyeball / cherrypick this one as needed.

@tseaver tseaver closed this Jan 7, 2015
@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

Thanks

@tseaver tseaver deleted the 477-prepare_to_remove_dataset branch January 7, 2015 20:34
tseaver added a commit that referenced this pull request Jan 7, 2015
@tseaver
Merge pull request #501 from tseaver/cherrypick-499
0eca209 
Cherry pick cleanups from #499.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@release-please
chore(main): release 2.18.0 (#499)
b30fdff 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@release-please
chore(main): release 2.18.0 (#499)
a6fb3a8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@release-please
chore(main): release 2.18.0 (#499)
1dd11ae 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@release-please
chore(main): release 2.18.0 (#499)
c6b7881 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow-cx to v1.18.0 (#…
ccb5e8a 
…499)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@jeffreyaiatgoogle @dandhlee
chore(samples): Adds code examples to create, get, list, update and d…
1df7389 
…elete a SavedQuery (#499)

* Change the comment of BatchGetEffectiveIamPolicies to be more accurate.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_delete_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_delete_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency backoff to v2.2.1 (#499)
4bdb89e
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pillow to v9.3.0 (#499)
78f777c
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 2.18.0 (#499)
046a200 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @coveralls