Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#825: Allow passing explicit connection to 'Blob.make_public' #855

Merged
merged 2 commits into from
May 7, 2015
Merged

#825: Allow passing explicit connection to 'Blob.make_public' #855

merged 2 commits into from
May 7, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 1, 2015

Requires #853 as a base.

See #825.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 1, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2015
@tseaver tseaver mentioned this pull request May 1, 2015
Closed
@tseaver tseaver changed the title #825: Allow passing explicit connetion to 'Blob.make_public' #825: Allow passing explicit connection to 'Blob.make_public' May 1, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 02ce8e1 on tseaver:825-storage_blob_make_public-explicit_connection into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor

dhermes commented May 4, 2015

Ping me on this when we resolve #853

@tseaver
Copy link
Contributor Author

tseaver commented May 4, 2015

Rebased against updated branch for #853. Adjusted Blob.make_public to forward connection w/o subsitution to ACL.save.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d8e7d5f on tseaver:825-storage_blob_make_public-explicit_connection into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2015

Rebased again against updated branch for #853.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2478c71 on tseaver:825-storage_blob_make_public-explicit_connection into 73a341c on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2015

@dhermes any remaining issues?

@dhermes
Copy link
Contributor

dhermes commented May 6, 2015

Have yet to review this, was waiting on the diffbase to go through. Can you rebase and ping me?

@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2015

@dhermes I rebased it this morning on the latest from #853.

@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2015

OIC, you'd like a rebase against master.

@dhermes
Copy link
Contributor

dhermes commented May 6, 2015

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad0557d on tseaver:825-storage_blob_make_public-explicit_connection into aafcd2a on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request May 7, 2015
@tseaver
Merge pull request #855 from tseaver/825-storage_blob_make_public-exp…
d134452 
…licit_connection

#825:  Allow passing explicit connection to 'Blob.make_public'
@tseaver tseaver merged commit d134452 into googleapis:master May 7, 2015
@tseaver tseaver deleted the 825-storage_blob_make_public-explicit_connection branch May 7, 2015 04:31
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @coveralls @dhermes @googlebot