Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lazy property #991

Merged
merged 1 commit into from
Jul 21, 2015
Merged

Remove lazy property #991

merged 1 commit into from
Jul 21, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Has #990 as diffbase

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jul 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
dhermes referenced this pull request in dhermes/google-cloud-python Jul 14, 2015
@dhermes
Removing _implicit_environ from storage.
e627eaa 
Towards googleapis#952.
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

@dhermes ping me after #990 lands (a rebase would help review).

@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

Will do

@dhermes dhermes mentioned this pull request Jul 20, 2015
Merged
@dhermes dhermes force-pushed the remove-lazy-property branch from f3fdfd7 to 726d000 Compare July 20, 2015 21:26
@dhermes dhermes force-pushed the remove-lazy-property branch from 726d000 to 40192ce Compare July 21, 2015 02:33
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

@tseaver Rebased

@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 21, 2015
@dhermes
Merge pull request #991 from dhermes/remove-lazy-property
6b342ea 
Remove lazy property
@dhermes dhermes merged commit 6b342ea into googleapis:master Jul 21, 2015
@dhermes dhermes deleted the remove-lazy-property branch July 21, 2015 02:42
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot