Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing outdated storage test names and test cases. #992

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Has #990 as diffbase

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
@dhermes dhermes force-pushed the storage-rename-tests branch 2 times, most recently from 016c57d to ea78a7a Compare July 20, 2015 21:27
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

@dhermes ping me after #990 lands (a rebase would help review).

Also addressing a few docstrings that weren't changed
during the transition to clients (from implicit).
@dhermes dhermes force-pushed the storage-rename-tests branch from ea78a7a to 462f0a9 Compare July 21, 2015 02:34
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2015

@tseaver Rebased (this does not depend on #991, so you can review in any order you wish)

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 21, 2015
Fixing outdated storage test names and test cases.
@dhermes dhermes merged commit 113a50f into googleapis:master Jul 21, 2015
@dhermes dhermes deleted the storage-rename-tests branch July 21, 2015 02:42
@dhermes dhermes mentioned this pull request Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants