Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084

Merged
merged 11 commits into from
Apr 25, 2023

Conversation

GaoleMeng
Copy link
Contributor

Since write api server side per request timeout is 2 minutes, it does not make sense to wait 15 minutes to determine whether a connection has been dead, reducing it to 3 minutes

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@GaoleMeng GaoleMeng requested a review from a team as a code owner April 22, 2023 00:52
@GaoleMeng GaoleMeng requested a review from prash-mi April 22, 2023 00:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Apr 22, 2023
@GaoleMeng GaoleMeng changed the title fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes and rephrase the log a bit Apr 22, 2023
@GaoleMeng GaoleMeng requested a review from yirutang April 22, 2023 00:54
…eue.

Since in write api server side we have total timeout of 2 minutes, it
does not make sense to wait 15 minutes to determine whether we have met
dead connection, let's reduce the timeout here
@GaoleMeng GaoleMeng changed the title fix: Reduce timeout of waiting in queue from 15 minutes to 3 minutes and rephrase the log a bit fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit Apr 22, 2023
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner April 25, 2023 00:18
@GaoleMeng GaoleMeng merged commit fe25f38 into googleapis:main Apr 25, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants