Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084

Merged
merged 11 commits into from
Apr 25, 2023
Merged

fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1726c85
feat: add public api to stream writer to set the maximum wait time
GaoleMeng Mar 30, 2023
9b9e420
Merge branch 'googleapis:main' into main
GaoleMeng Mar 30, 2023
3f0c5eb
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 30, 2023
a448c8b
modify back the readme change from owl post processor
GaoleMeng Mar 30, 2023
b15b140
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 31, 2023
4f5c0ad
Merge branch 'googleapis:main' into main
GaoleMeng Mar 31, 2023
aa6d9c6
Merge branch 'googleapis:main' into main
GaoleMeng Apr 3, 2023
7055043
Merge branch 'googleapis:main' into main
GaoleMeng Apr 14, 2023
ea2e8fb
Merge branch 'googleapis:main' into main
GaoleMeng Apr 22, 2023
affa11a
fix: Reduce the timeout to 5 minutes for the requests wait time in qu…
GaoleMeng Apr 22, 2023
60869f7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.12.0')
implementation platform('com.google.cloud:libraries-bom:26.13.0')

implementation 'com.google.cloud:google-cloud-bigquerystorage'
```
Expand Down
6 changes: 3 additions & 3 deletions ...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ConnectionWorker implements AutoCloseable {
* We will constantly checking how much time we have been waiting for the next request callback
* if we wait too much time we will start shutting down the connections and clean up the queues.
*/
static Duration MAXIMUM_REQUEST_CALLBACK_WAIT_TIME = Duration.ofMinutes(15);
static Duration MAXIMUM_REQUEST_CALLBACK_WAIT_TIME = Duration.ofMinutes(5);

private Lock lock;
private Condition hasMessageInWaitingQueue;
Expand Down Expand Up @@ -321,7 +321,7 @@ public void run() {
}

private void resetConnection() {
log.info("Reconnecting for stream:" + streamName + " id: " + writerId);
log.info("Start connecting stream: " + streamName + " id: " + writerId);
if (this.streamConnection != null) {
// It's safe to directly close the previous connection as the in flight messages
// will be picked up by the next connection.
Expand All @@ -344,7 +344,7 @@ public void run(Throwable finalStatus) {
doneCallback(finalStatus);
}
});
log.info("Reconnect done for stream:" + streamName + " id: " + writerId);
log.info("Finish connecting stream: " + streamName + " id: " + writerId);
}

/** Schedules the writing of rows at given offset. */
Expand Down