No longer using GAX batching for WriteLogEntries

[jamestep]

After some investigation, it seems like since version 2.1.4 of this library, WriteLogEntries is no longer using GAX batching.

This is the specific line that's an issue, which changed in this commit. It switched from createBatchingCallable to createUnaryCallable, despite keeping the BatchingCallSettings logic.

I understand the issue may not be in this library, but I'm not familiar with microgenerator / gapic / autosynth / synthtool and this seemed like a good place to start.

This issue means we are unable to update beyond 2.1.3 as we hit the GCP WriteLogEntries request quota very quickly.

[jamestep]

Some important additional info: Here is the gapic yaml with the batching definition for WriteLogEntries from googleapis. It does seem to have moved around / between files over time.

[minherz]

@Neenu1995 can you have a look into this issue, please.

[minherz]

@jamestep we have had similar discussion in googleapis/java-logging-logback#134. Do you have additional info showing that batching does not work?

[jamestep]

Yes I do have some additional info:

• For our project, hitting the GCP "Log ingestion requests per minute" with the only change being the version of google-cloud-logging
• This line in 2.1.3 in GrpcLoggingServiceV2Stub which changed to this line in 2.1.4.
• As indicated by others, there are BatchingCallSettings for writeLogEntries. But from the above code change it is clear that writeLogEntriesCallable switched from being created with createBatchingCallable to being created with createUnaryCallable. createUnaryCallable will not perform any batching, even if provided with batching settings.
• The debugging screenshots below

See below when debugging, writeLogEntries is created with createBatchingCallable in 2.1.3:

And then BatchingCallable / BatchedFuture is used:

But then debugging 2.1.4, writeLogEntries is created with createUnaryCallable:

And then BatchingCallable / BatchedFuture is never used:

[minherz]

Thank you for this info. We need to check the problem with auto-generated code and will update you about next steps soon.
Please mind that the currently supported version of the library is 3.2.0. We will run the tests to see batching behavior on this version.

[minherz]

Thank you for your patience. We've confirmed the problem. Hopefully, it will be addressed in the next release. The release time will be dependent on the gapic generator fix.

[minherz]

Fixed in #726