Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.0 release notes should mention the fix for issue #632 #848

Closed
xhanin opened this issue Jan 25, 2022 · 2 comments
Closed

v3.4.0 release notes should mention the fix for issue #632 #848

xhanin opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. type: question Request for information or clarification. Not an issue.

Comments

@xhanin
Copy link

xhanin commented Jan 25, 2022

After quite a long time investigating on performance and DEADLINE_EXCEEDED errors on a production server, I found this issue (which is not on that project, but we use the logback appender):
googleapis/java-logging-logback#651

One comment is referencing the issue #632 on this project, and says it is part of version 3.4.0.

The release notes of that version do not mention the fix, despite the heavy impact of the bug / fix:
https://github.com/googleapis/java-logging/releases/tag/v3.4.0

If I understand the code correctly, it means that all versions between 2.1.4 and 3.4.0 (last november) were using single unary calls for each write log call, i.e. every single log when using the logback appender. The difference seems very important compared to batching calls, and has led us to situations exhausting the resources of a production server by stacking a high number of threads (we reached number like grpc-default-executor-10011 in 10k+ logs of type DEADLINE_EXCEEDED).

So I'm surprised that such a big issue is mentionned only on a "cryptic" issue name ("No longer using GAX batching for WriteLogEntries" is cryptic for people only using a logback appender and assuming it works).

I think that would deserve better documentation, at least on the v3.4.0 release notes, but I would add something on the main README of both this project and googleapis/java-logging-logback (in the Optimize log ingestion section) to inform users and ask to upgrade their version.

What do you think? Did I misunderstood the problem? Maybe the batching is not so important, and in our case the DEADLINE_EXCEEDED errors are related to something else and will probably still happen after an upgrade with the fix for #632?

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 25, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 26, 2022
@minherz minherz added type: question Request for information or clarification. Not an issue. and removed triage me I really want to be triaged. labels Jan 28, 2022
@minherz
Copy link
Contributor

minherz commented Jan 28, 2022

Hi,
The release notes are auto-generated. We will see if it is possible to add this information into the release notes.

@minherz
Copy link
Contributor

minherz commented Jan 30, 2022

The release notes in the Github were update.

@minherz minherz closed this as completed Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

4 participants