test: add test for maven-javadoc-plugin version#662
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
Member
|
How is it going? |
product-auto-label
bot
added
size: m
suztomo
reviewed
Oct 4, 2023
| - run: java -version | ||
| - run: sudo apt-get update -y | ||
| - run: sudo apt-get install libxml2-utils | ||
| - run: .kokoro/javadoc-generation-with-doclet.sh ${{matrix.repo}} |
Member
There was a problem hiding this comment.
Can you rename the script to client-library-check-javadoc-with-doclet.sh? I want the name to tell it's similar to client-library-check.sh.
suztomo
approved these changes
Oct 4, 2023
Member
suztomo
left a comment
suztomo
left a comment
There was a problem hiding this comment.
Approving. Can you rename the script to client-library-check-javadoc-with-doclet.sh? I want the name to tell it's similar to client-library-check.sh.
Member
|
"Kokoro - Test: Docker Image Validation" has been failing. This pull request is irrelevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #661