Skip to content

Revert "build(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.6.0"#671

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
revert-656-renovate/org.apache.maven.plugins-maven-javadoc-plugin-3.x
Oct 4, 2023
Merged

Revert "build(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.6.0"#671
gcf-merge-on-green[bot] merged 2 commits intomainfrom
revert-656-renovate/org.apache.maven.plugins-maven-javadoc-plugin-3.x

Conversation

@alicejli
Copy link
Contributor

@alicejli alicejli commented Oct 4, 2023

Reverts #656

This version update currently breaks javadoc generation with v1.9.0+ of the doclet used for Cloud RAD.

…-javadoc-plugin to v3.6.0 (#656)"

This reverts commit 1724433.
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 4, 2023
@suztomo suztomo closed this Oct 4, 2023
@suztomo suztomo reopened this Oct 4, 2023
@suztomo
Copy link
Member

suztomo commented Oct 4, 2023

I just merged #662. Let's see "downstream / javadoc-with-doclet (java-bigtable)".

@suztomo
Copy link
Member

suztomo commented Oct 4, 2023

downstream / javadoc-with-doclet (java-bigtable) (pull_request) Failing after 1m

Error: 4:087 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.0:aggregate (default-cli) on project google-cloud-bigtable-parent: Execution default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.0:aggregate failed: If a non-null excludes list is given, all elements must be non-null -> [Help 1]

https://github.com/googleapis/java-shared-config/actions/runs/6411009761/job/17405535175?pr=671

It seems the build used an old commit.

@suztomo
Copy link
Member

suztomo commented Oct 4, 2023

The java-bigtable repository declares the independent version (unnecessarily?).

googleapis/java-bigtable#1924

@alicejli alicejli marked this pull request as ready for review October 4, 2023 20:19
@alicejli alicejli requested a review from a team as a code owner October 4, 2023 20:19
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 778a547 into main Oct 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the revert-656-renovate/org.apache.maven.plugins-maven-javadoc-plugin-3.x branch October 4, 2023 20:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2023
@suztomo suztomo added the release-please:force-run To run release-please label Oct 4, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants