Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support analyzeUpdate for DML statements #1866

Closed
olavloite opened this issue May 2, 2022 · 0 comments · Fixed by #1867
Closed

Support analyzeUpdate for DML statements #1866

olavloite opened this issue May 2, 2022 · 0 comments · Fixed by #1867
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Collaborator

Queries can be analyzed using the analyzeQuery method and the analyze modes PLAN and PROFILE. The same is currently not supported for DML statements.
@olavloite olavloite added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 2, 2022
@olavloite olavloite self-assigned this May 2, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label May 2, 2022
olavloite added a commit that referenced this issue May 2, 2022
@olavloite
feat: support analyzeUpdate
951cc6f 
Adds support for analyzeUpdate for DML statements, similarly to
analyzeQuery for DQL statements. Executing a DML statement in PLAN mode
only returns the query plan, but does not actually execute the
statement. Executing a DML statement in PROFILE mode executes the
statement and returns the query plan and execution statistics.

Fixes #1866
@olavloite olavloite mentioned this issue May 2, 2022
Merged
olavloite added a commit that referenced this issue May 16, 2022
@olavloite @gcf-owl-bot
feat: support analyzeUpdate (#1867)
2d8cfa4 
* feat: support analyzeUpdate

Adds support for analyzeUpdate for DML statements, similarly to
analyzeQuery for DQL statements. Executing a DML statement in PLAN mode
only returns the query plan, but does not actually execute the
statement. Executing a DML statement in PROFILE mode executes the
statement and returns the query plan and execution statistics.

Fixes #1866

* test: fix integration test

* build: add ignored differences to clirr

* fix: plan returns zero row count

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support analyzeUpdate googleapis/java-spanner
1 participant
@olavloite