Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support analyzeUpdate #1867

Merged
merged 6 commits into from
May 16, 2022
Merged

feat: support analyzeUpdate #1867

merged 6 commits into from
May 16, 2022

Conversation

olavloite
Copy link
Collaborator

Adds support for analyzeUpdate for DML statements, similarly to
analyzeQuery for DQL statements. Executing a DML statement in PLAN mode
only returns the query plan, but does not actually execute the
statement. Executing a DML statement in PROFILE mode executes the
statement and returns the query plan and execution statistics.

Fixes #1866

Adds support for analyzeUpdate for DML statements, similarly to
analyzeQuery for DQL statements. Executing a DML statement in PLAN mode
only returns the query plan, but does not actually execute the
statement. Executing a DML statement in PROFILE mode executes the
statement and returns the query plan and execution statistics.

Fixes #1866
@olavloite olavloite requested a review from a team as a code owner May 2, 2022 18:25
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels May 2, 2022
@olavloite olavloite requested a review from a team as a code owner May 3, 2022 05:12
@olavloite
Copy link
Collaborator Author

@rajatbhatta @ansh0l Friendly ping. Would you mind giving this a review? This feature is needed for the DescribeStatement message in PGAdapter.

Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had gone through these changes, but had missed adding my LGTM. Approving now.

@olavloite olavloite merged commit 2d8cfa4 into main May 16, 2022
@olavloite olavloite deleted the analyze-update branch May 16, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support analyzeUpdate for DML statements
2 participants