Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error handling for Downloads #2043

Merged
merged 7 commits into from
Jun 6, 2023
Merged

feat: Error handling for Downloads #2043

merged 7 commits into from
Jun 6, 2023

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner June 2, 2023 18:36
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Jun 2, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 2, 2023
@sydney-munro sydney-munro marked this pull request as draft June 5, 2023 16:31
@sydney-munro sydney-munro force-pushed the download-error-handling branch from dde6d6c to 6a77139 Compare June 5, 2023 16:32
@sydney-munro sydney-munro marked this pull request as ready for review June 5, 2023 16:38
@sydney-munro sydney-munro requested a review from BenWhitehead June 5, 2023 18:15
@sydney-munro sydney-munro merged commit cf10576 into feat/transfer-manager Jun 6, 2023
@sydney-munro sydney-munro deleted the download-error-handling branch June 6, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-munro @BenWhitehead