Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 4.0.0 #1234

Merged
merged 7 commits into from
Jun 24, 2020
Merged

chore: release 4.0.0 #1234

merged 7 commits into from
Jun 24, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Jun 24, 2020

🤖 I have created a release *beep* *boop*

4.0.0 (2020-06-24)

⚠ BREAKING CHANGES

Features

Bug Fix


This PR was generated with Release Please.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          30       30           
  Lines       18545    18545           
  Branches     1422     1422           
=======================================
  Hits        18268    18268           
  Misses        274      274           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93011d...a5582ce. Read the comment docs.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated
### Features

* add support for serialization to BigInt `(via settings({useBigInt: true})` (#1016)
* add support for set() with SetOptions when using `FirestoreDataConverte` (#1087)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Converte/Converter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated
### ⚠ BREAKING CHANGES

* drop Node 8 support (#1006)
* the `FirestoreDataConverter` is now called with a `QueryDocumentSnapshot` instead of `DocumentData` (#965)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .fromFirestore() to FirestoreDataConverter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@schmidt-sebastian schmidt-sebastian merged commit bab9d3a into master Jun 24, 2020
@yoshi-automation
Copy link
Contributor

@publish-bot publish-bot bot removed autorelease: tagged cla: yes This human has signed the Contributor License Agreement. labels Jun 24, 2020
@schmidt-sebastian schmidt-sebastian deleted the release-v4.0.0 branch June 24, 2020 21:56
@jrthib
Copy link

jrthib commented Jun 25, 2020

Are there plans to add this release to https://github.com/firebase/firebase-admin-node?

@schmidt-sebastian
Copy link
Contributor

schmidt-sebastian commented Jun 25, 2020

For compatibility with other Firebase offerings that continue to rely on Node 8 support, the upgrade to firebase-admin-node will be delayed by a couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants