Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run synthtool after node10 merge #1235

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do you happen to know why the sample/system tests are failing in CI?

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1235 into master will increase coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   98.44%   98.50%   +0.05%     
==========================================
  Files          30       30              
  Lines       18539    18545       +6     
  Branches     1425     1422       -3     
==========================================
+ Hits        18251    18268      +17     
+ Misses        285      274      -11     
  Partials        3        3              
Impacted Files Coverage Δ
dev/src/v1/firestore_admin_client.ts 98.78% <92.30%> (+0.26%) ⬆️
dev/src/v1/firestore_client.ts 98.12% <92.30%> (+0.25%) ⬆️
dev/src/v1beta1/firestore_client.ts 97.70% <92.30%> (+0.31%) ⬆️
dev/src/backoff.ts 98.62% <0.00%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56355f1...4517923. Read the comment docs.

@schmidt-sebastian
Copy link
Contributor Author

Excluded the Kokoro conf changes to make the CI green.

@schmidt-sebastian schmidt-sebastian merged commit c93011d into master Jun 24, 2020
@release-please release-please bot mentioned this pull request Jun 24, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/runsynth branch June 24, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants