feat: add support for asynchronous rest streaming #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Could you "fork" the file you're refactoring from into the file you're refacotring "to", adapting the dirctions in https://devblogs.microsoft.com/oldnewthing/20190919-00/?p=102904 ? It will make it easier to review, and preserve git history for the future.
ohmayr
force-pushed
the
add-support-for-async-rest-streaming
branch
from
29d662b
to
fdeb437
Compare
…gleapis/python-api-core into add-support-for-async-rest-streaming
|
I will move |
vchudnov-g
approved these changes
Aug 26, 2024
google/api_core/rest_streaming.py
Outdated
| ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
| ValueError: | ||
| - If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
| - If `response` is not an instance of `requests.Response`. |
There was a problem hiding this comment.
Where is this exception raised? Line 46 will succeed with a matching method of any class, right?
There was a problem hiding this comment.
I think it's reasonable to not raise an error for this. We've added the relevant type hints. Cleaned up the docstring.
…gleapis/python-api-core into add-support-for-async-rest-streaming
ohmayr
added
the
do not merge
ohmayr
commented
Sep 2, 2024
ohmayr
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for asynchronous rest streaming in core to be leveraged in GAPICs.
The changes in this PR can be tested against: googleapis/google-auth-library-python#1577.