Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for asynchronous rest streaming #686

Merged
merged 30 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4df2120
duplicating file to base
ohmayr Aug 23, 2024
26f52a5
restore original file
ohmayr Aug 23, 2024
204920a
duplicate file to async
ohmayr Aug 23, 2024
2014ef6
restore original file
ohmayr Aug 23, 2024
fdeb437
Merge branch 'dups' into add-support-for-async-rest-streaming
ohmayr Aug 23, 2024
8014f47
duplicate test file for async
ohmayr Aug 23, 2024
e84f03a
restore test file
ohmayr Aug 23, 2024
91f5c13
Merge branch 'dups' into add-support-for-async-rest-streaming
ohmayr Aug 23, 2024
0c2ee5c
feat: add support for asynchronous rest streaming
ohmayr Aug 23, 2024
75ae7d7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 23, 2024
db7cfb3
fix naming issue
ohmayr Aug 23, 2024
9da0113
Merge branch 'add-support-for-async-rest-streaming' of github.com:goo…
ohmayr Aug 23, 2024
87eeca3
fix import module name
ohmayr Aug 23, 2024
d6abddd
pull auth feature branch
ohmayr Aug 23, 2024
a6a648d
revert setup file
ohmayr Aug 23, 2024
8d30b2d
address PR comments
ohmayr Aug 24, 2024
0b51b09
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 24, 2024
7d8f1e1
run black
ohmayr Aug 24, 2024
d793069
address PR comments
ohmayr Aug 27, 2024
5f48f72
Merge branch 'add-support-for-async-rest-streaming' of github.com:goo…
ohmayr Aug 27, 2024
70d1cdb
update nox coverage
ohmayr Aug 27, 2024
ee3a5ac
address PR comments
ohmayr Aug 27, 2024
5a6e488
fix nox session name in workflow
ohmayr Aug 27, 2024
f2180da
use https for remote repo
ohmayr Aug 27, 2024
bc811e5
add context manager methods
ohmayr Aug 27, 2024
fc74ae0
address PR comments
ohmayr Sep 11, 2024
1603818
Merge branch 'main' into add-support-for-async-rest-streaming
ohmayr Sep 11, 2024
cee06ab
update auth error versions
ohmayr Sep 18, 2024
380dedf
Merge branch 'main' into add-support-for-async-rest-streaming
ohmayr Sep 18, 2024
750d4cb
update import error
ohmayr Sep 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
option: ["", "_grpc_gcp", "_wo_grpc", "_with_prerelease_deps"]
option: ["", "_grpc_gcp", "_wo_grpc", "_with_prerelease_deps", "_with_auth_aio"]
python:
- "3.7"
- "3.8"
Expand Down
118 changes: 118 additions & 0 deletions google/api_core/_rest_streaming_base.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Helpers for server-side streaming in REST."""

from collections import deque
import string
from typing import Deque, Union
import types

import proto
import google.protobuf.message
from google.protobuf.json_format import Parse


class BaseResponseIterator:
"""Base Iterator over REST API responses. This class should not be used directly.

Args:
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response
class expected to be returned from an API.

Raises:
ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
"""

def __init__(
self,
response_message_cls: Union[proto.Message, google.protobuf.message.Message],
):
self._response_message_cls = response_message_cls
# Contains a list of JSON responses ready to be sent to user.
self._ready_objs: Deque[str] = deque()
# Current JSON response being built.
self._obj = ""
# Keeps track of the nesting level within a JSON object.
self._level = 0
# Keeps track whether HTTP response is currently sending values
# inside of a string value.
self._in_string = False
# Whether an escape symbol "\" was encountered.
self._escape_next = False

self._grab = types.MethodType(self._create_grab(), self)

def _process_chunk(self, chunk: str):
if self._level == 0:
if chunk[0] != "[":
raise ValueError(
"Can only parse array of JSON objects, instead got %s" % chunk
)
for char in chunk:
if char == "{":
if self._level == 1:
# Level 1 corresponds to the outermost JSON object
# (i.e. the one we care about).
self._obj = ""
if not self._in_string:
self._level += 1
self._obj += char
elif char == "}":
self._obj += char
if not self._in_string:
self._level -= 1
if not self._in_string and self._level == 1:
self._ready_objs.append(self._obj)
elif char == '"':
# Helps to deal with an escaped quotes inside of a string.
if not self._escape_next:
self._in_string = not self._in_string
self._obj += char
elif char in string.whitespace:
if self._in_string:
self._obj += char
elif char == "[":
if self._level == 0:
self._level += 1
else:
self._obj += char
elif char == "]":
if self._level == 1:
self._level -= 1
else:
self._obj += char
else:
self._obj += char
self._escape_next = not self._escape_next if char == "\\" else False

def _create_grab(self):
if issubclass(self._response_message_cls, proto.Message):

def grab(this):
return this._response_message_cls.from_json(
this._ready_objs.popleft(), ignore_unknown_fields=True
)

return grab
elif issubclass(self._response_message_cls, google.protobuf.message.Message):

def grab(this):
return Parse(this._ready_objs.popleft(), this._response_message_cls())

return grab
else:
raise ValueError(
"Response message class must be a subclass of proto.Message or google.protobuf.message.Message."
)
83 changes: 9 additions & 74 deletions google/api_core/rest_streaming.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,15 @@

"""Helpers for server-side streaming in REST."""

from collections import deque
import string
from typing import Deque, Union
from typing import Union

import proto
import requests
import google.protobuf.message
from google.protobuf.json_format import Parse
from google.api_core._rest_streaming_base import BaseResponseIterator


class ResponseIterator:
class ResponseIterator(BaseResponseIterator):
vchudnov-g marked this conversation as resolved.
Show resolved Hide resolved
"""Iterator over REST API responses.

Args:
Expand All @@ -33,7 +31,9 @@ class ResponseIterator:
class expected to be returned from an API.

Raises:
ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
ValueError:
- If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
ohmayr marked this conversation as resolved.
Show resolved Hide resolved
- If `response` is not an instance of `requests.Response`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this exception raised? Line 46 will succeed with a matching method of any class, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to not raise an error for this. We've added the relevant type hints. Cleaned up the docstring.

"""

def __init__(
Expand All @@ -42,68 +42,16 @@ def __init__(
response_message_cls: Union[proto.Message, google.protobuf.message.Message],
):
self._response = response
self._response_message_cls = response_message_cls
# Inner iterator over HTTP response's content.
self._response_itr = self._response.iter_content(decode_unicode=True)
# Contains a list of JSON responses ready to be sent to user.
self._ready_objs: Deque[str] = deque()
# Current JSON response being built.
self._obj = ""
# Keeps track of the nesting level within a JSON object.
self._level = 0
# Keeps track whether HTTP response is currently sending values
# inside of a string value.
self._in_string = False
# Whether an escape symbol "\" was encountered.
self._escape_next = False
super(ResponseIterator, self).__init__(
response_message_cls=response_message_cls
)

def cancel(self):
"""Cancel existing streaming operation."""
self._response.close()

def _process_chunk(self, chunk: str):
if self._level == 0:
if chunk[0] != "[":
raise ValueError(
"Can only parse array of JSON objects, instead got %s" % chunk
)
for char in chunk:
if char == "{":
if self._level == 1:
# Level 1 corresponds to the outermost JSON object
# (i.e. the one we care about).
self._obj = ""
if not self._in_string:
self._level += 1
self._obj += char
elif char == "}":
self._obj += char
if not self._in_string:
self._level -= 1
if not self._in_string and self._level == 1:
self._ready_objs.append(self._obj)
elif char == '"':
# Helps to deal with an escaped quotes inside of a string.
if not self._escape_next:
self._in_string = not self._in_string
self._obj += char
elif char in string.whitespace:
if self._in_string:
self._obj += char
elif char == "[":
if self._level == 0:
self._level += 1
else:
self._obj += char
elif char == "]":
if self._level == 1:
self._level -= 1
else:
self._obj += char
else:
self._obj += char
self._escape_next = not self._escape_next if char == "\\" else False

def __next__(self):
while not self._ready_objs:
try:
Expand All @@ -115,18 +63,5 @@ def __next__(self):
raise e
return self._grab()

def _grab(self):
# Add extra quotes to make json.loads happy.
if issubclass(self._response_message_cls, proto.Message):
return self._response_message_cls.from_json(
self._ready_objs.popleft(), ignore_unknown_fields=True
)
elif issubclass(self._response_message_cls, google.protobuf.message.Message):
return Parse(self._ready_objs.popleft(), self._response_message_cls())
else:
raise ValueError(
"Response message class must be a subclass of proto.Message or google.protobuf.message.Message."
)

def __iter__(self):
return self
85 changes: 85 additions & 0 deletions google/api_core/rest_streaming_async.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Helpers for asynchronous server-side streaming in REST."""

from typing import Union

import proto

try:
import google.auth.aio.transport
except ImportError: # pragma: NO COVER
# TODO (ohmayr): Update this version once auth work is released.
raise ValueError(
"google-auth>=2.3x.x is required to use asynchronous rest streaming."
ohmayr marked this conversation as resolved.
Show resolved Hide resolved
)

import google.protobuf.message
from google.api_core._rest_streaming_base import BaseResponseIterator


class AsyncResponseIterator(BaseResponseIterator):
"""Asynchronous Iterator over REST API responses.

Args:
response (google.auth.aio.transport.Response): An API response object.
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response
class expected to be returned from an API.

Raises:
ValueError:
- If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`.
- If `response` is not an instance of a subclass of `google.auth.aio.transport.Response`.
"""

def __init__(
self,
response: google.auth.aio.transport.Response,
response_message_cls: Union[proto.Message, google.protobuf.message.Message],
):
self._response = response
self._chunk_size = 1024
self._response_itr = self._response.content().__aiter__()
super(AsyncResponseIterator, self).__init__(
response_message_cls=response_message_cls
)

async def __aenter__(self):
return self

async def cancel(self):
"""Cancel existing streaming operation."""
await self._response.close()

async def __anext__(self):
while not self._ready_objs:
try:
chunk = await self._response_itr.__anext__()
chunk = chunk.decode("utf-8")
self._process_chunk(chunk)
except StopAsyncIteration as e:
if self._level > 0:
raise ValueError("i Unfinished stream: %s" % self._obj)
raise e
except ValueError as e:
raise e
return self._grab()

def __aiter__(self):
return self

async def __aexit__(self, exc_type, exc, tb):
"""Cancel existing async streaming operation."""
await self._response.close()
14 changes: 13 additions & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"unit",
"unit_grpc_gcp",
"unit_wo_grpc",
"unit_with_auth_aio",
"cover",
"pytype",
"mypy",
Expand Down Expand Up @@ -109,7 +110,7 @@ def install_prerelease_dependencies(session, constraints_path):
session.install(*other_deps)


def default(session, install_grpc=True, prerelease=False):
def default(session, install_grpc=True, prerelease=False, install_auth_aio=False):
"""Default unit test session.

This is intended to be run **without** an interpreter set, so
Expand Down Expand Up @@ -144,6 +145,11 @@ def default(session, install_grpc=True, prerelease=False):
f"{constraints_dir}/constraints-{session.python}.txt",
)

if install_auth_aio:
session.install(
"google-auth @ git+https://git@github.com/googleapis/google-auth-library-python@8833ad6f92c3300d6645355994c7db2356bd30ad"
)

# Print out package versions of dependencies
session.run(
"python", "-c", "import google.protobuf; print(google.protobuf.__version__)"
Expand Down Expand Up @@ -229,6 +235,12 @@ def unit_wo_grpc(session):
default(session, install_grpc=False)


@nox.session(python=PYTHON_VERSIONS)
def unit_with_auth_aio(session):
"""Run the unit test suite with google.auth.aio installed"""
default(session, install_auth_aio=True)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
Expand Down
Loading