Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add client side lib id with lib version #760

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@yirutang yirutang requested review from a team as code owners March 18, 2024 23:27
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Mar 18, 2024
@Linchin
Copy link
Contributor

Linchin commented Mar 19, 2024

Thank you @yirutang, just so I understand the PR better, could you let me know if this PR is only changing the generated code? Also, I see a lot of changes with import formats, but where is client side lib id added?

@yirutang
Copy link
Contributor Author

Thank you @yirutang, just so I understand the PR better, could you let me know if this PR is only changing the generated code? Also, I see a lot of changes with import formats, but where is client side lib id added?

Yes, there is a few lines of additions here, in py_writer. I ran the suggested nox -r -s format and it did all these sortings for me. Maybe it is not needed? Let me revert the changes back.

@yirutang yirutang closed this Mar 19, 2024
@yirutang yirutang reopened this Mar 19, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: l Pull request size is large. labels Mar 19, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 19, 2024
@yirutang yirutang enabled auto-merge (squash) March 19, 2024 20:55
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yirutang! Question unrelated to approval: where on the backend will the version data be available?

@yirutang yirutang merged commit 05664dc into googleapis:main Mar 19, 2024
24 checks passed
@yirutang
Copy link
Contributor Author

Thank you @yirutang! Question unrelated to approval: where on the backend will the version data be available?

It will be BQ backend's general logging (helixdata2), which is a project in BQ itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants