-
Notifications
You must be signed in to change notification settings - Fork 302
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: move system tests into
tests/system directory (#475)
This aligns more closely with the templates from synthtool. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Towards #366
- Loading branch information
Showing
4 changed files
with
111 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright 2021 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| # Copyright 2020 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """System tests for Jupyter/IPython connector.""" | ||
|
|
||
| import re | ||
|
|
||
| import pytest | ||
| import psutil | ||
|
|
||
|
|
||
| IPython = pytest.importorskip("IPython") | ||
| io = pytest.importorskip("IPython.utils.io") | ||
| pandas = pytest.importorskip("pandas") | ||
| tools = pytest.importorskip("IPython.testing.tools") | ||
| interactiveshell = pytest.importorskip("IPython.terminal.interactiveshell") | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def ipython(): | ||
| config = tools.default_config() | ||
| config.TerminalInteractiveShell.simple_prompt = True | ||
| shell = interactiveshell.TerminalInteractiveShell.instance(config=config) | ||
| return shell | ||
|
|
||
|
|
||
| @pytest.fixture() | ||
| def ipython_interactive(ipython): | ||
| """Activate IPython's builtin hooks | ||
| for the duration of the test scope. | ||
| """ | ||
| with ipython.builtin_trap: | ||
| yield ipython | ||
|
|
||
|
|
||
| def test_bigquery_magic(ipython_interactive): | ||
| ip = IPython.get_ipython() | ||
| current_process = psutil.Process() | ||
| conn_count_start = len(current_process.connections()) | ||
|
|
||
| ip.extension_manager.load_extension("google.cloud.bigquery") | ||
| sql = """ | ||
| SELECT | ||
| CONCAT( | ||
| 'https://stackoverflow.com/questions/', | ||
| CAST(id as STRING)) as url, | ||
| view_count | ||
| FROM `bigquery-public-data.stackoverflow.posts_questions` | ||
| WHERE tags like '%google-bigquery%' | ||
| ORDER BY view_count DESC | ||
| LIMIT 10 | ||
| """ | ||
| with io.capture_output() as captured: | ||
| result = ip.run_cell_magic("bigquery", "--use_rest_api", sql) | ||
|
|
||
| conn_count_end = len(current_process.connections()) | ||
|
|
||
| lines = re.split("\n|\r", captured.stdout) | ||
| # Removes blanks & terminal code (result of display clearing) | ||
| updates = list(filter(lambda x: bool(x) and x != "\x1b[2K", lines)) | ||
| assert re.match("Executing query with job ID: .*", updates[0]) | ||
| assert all(re.match("Query executing: .*s", line) for line in updates[1:-1]) | ||
| assert re.match("Query complete after .*s", updates[-1]) | ||
| assert isinstance(result, pandas.DataFrame) | ||
| assert len(result) == 10 # verify row count | ||
| assert list(result) == ["url", "view_count"] # verify column names | ||
|
|
||
| # NOTE: For some reason, the number of open sockets is sometimes one *less* | ||
| # than expected when running system tests on Kokoro, thus using the <= assertion. | ||
| # That's still fine, however, since the sockets are apparently not leaked. | ||
| assert conn_count_end <= conn_count_start # system resources are released |