Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: use templated noxfile + refactor tests #366

Closed
tswast opened this issue Nov 4, 2020 · 2 comments
Closed

process: use templated noxfile + refactor tests #366

tswast opened this issue Nov 4, 2020 · 2 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Nov 4, 2020

It'd be nice to stay consistent with the other libraries in how we perform tests.

Blocked by:
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 4, 2020
@meredithslota meredithslota added the type: process A process-related concern. May include testing, release, or the like. label Nov 4, 2020
@tswast
Copy link
Contributor Author

tswast commented Nov 4, 2020

This issue may be considered to be blocking: #336 as the SNIPPETS session is a custom session, which is not present in other libraries.

This was referenced Jan 19, 2021
Merged
Closed
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 20, 2021
@tswast
refactor: move system tests into tests/system directory (#475)
9f6556c 
This aligns more closely with the templates from synthtool.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Towards #366
@tswast tswast mentioned this issue Jan 22, 2021
Closed
3 tasks
@tswast tswast mentioned this issue Mar 11, 2021
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 15, 2021
@tswast
refactor: split pandas system tests to new module (#548)
efdf1c6 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Follow-up to #448

Towards #366
@plamut plamut mentioned this issue Jun 15, 2021
Closed
This was referenced Jul 19, 2021
Merged
Closed
@chalmerlowe chalmerlowe changed the title process: use templated noxfile process: use templated noxfile + refactor tests Sep 19, 2023
@chalmerlowe
Copy link
Contributor

Closing. A number of tests and such have been relocated to more appropriate locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @meredithslota @chalmerlowe