Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split pandas system tests to new module #548

Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 11, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to #448

Towards #366

@tswast tswast requested review from a team and shollyman and removed request for a team March 11, 2021 21:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 11, 2021
@tswast tswast requested a review from plamut March 11, 2021 21:00
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the system tests are getting some structure. 👍 I think it's good, but I did spot an incorrectly converted assertion.

BTW, in the future, I suggest keeping related changes in their own commits, as it makes it easier to glance over the diff and directly see the key differences. That assertion conversion could have been easily overlooked.

tests/system/test_pandas.py Outdated Show resolved Hide resolved
@tswast tswast requested a review from plamut March 15, 2021 14:40
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit efdf1c6 into googleapis:master Mar 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants