Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: copy all samples into samples/snippets #203

Closed
wants to merge 5 commits into from
Closed

chore: copy all samples into samples/snippets #203

wants to merge 5 commits into from

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jul 30, 2020 •
edited
Loading

TODO:

  • pin existing samples to commit hash
  • merge this PR
  • update samples to use master again

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
@busunkim96 busunkim96 changed the title chore: copy all samples into samples/snippest chore: copy all samples into samples/snippets Jul 30, 2020
@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
tseaver
tseaver suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting tests/__init__.py breaks Python 2.7 unit tests.

noxfile.py
session.run("py.test", os.path.join("docs", "snippets.py"), *session.posargs)
session.run("py.test", "samples", "--ignore=samples/snippets", *session.posargs)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to drop the linting of docs/samples below (Github isn't letting me leave the comment there).

@tswast
Copy link
Contributor

tswast commented Oct 16, 2020

Are we planning on continuing this PR? I notice that we just added a separate Kokoro config for the "snippets".

@tswast tswast mentioned this pull request Oct 19, 2020
Closed
1 task
@tswast tswast mentioned this pull request Nov 4, 2020
Closed
@meredithslota meredithslota requested a review from tswast January 12, 2021 18:16
@meredithslota
Copy link
Contributor

I feel like if this task still needs to be done, it might be more efficient to make a new PR — @tswast and @busunkim96 what do you think? cc: @leahecole and @steffnay for context.

@tswast
Copy link
Contributor

tswast commented Jan 22, 2021

Yes, we start fresh. I think we can consider this task to be part of #366.

@tswast tswast closed this Jan 22, 2021
@tswast tswast mentioned this pull request Jul 15, 2021
Closed
4 tasks
@tswast tswast deleted the move-samples branch July 27, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tswast @meredithslota @tseaver