Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "timeout" to retryable reasons #780

Closed
wants to merge 1 commit into from
Closed

Add "timeout" to retryable reasons #780

wants to merge 1 commit into from

Conversation

quentin-sommer
Copy link

Fixes #779

ℹ️ This modifies the default retry used for all the API calls. Should I instead make a retry object dedicated to the streaming inserts?

@quentin-sommer quentin-sommer requested a review from a team July 19, 2021 08:51
@quentin-sommer quentin-sommer requested a review from a team as a code owner July 19, 2021 08:51
@quentin-sommer quentin-sommer requested review from tswast and removed request for a team July 19, 2021 08:51
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2021
@tswast
Copy link
Contributor

tswast commented Aug 25, 2021

I'd like to see a stacktrace of the failure to confirm this is the right way to solve this.

One thing we might be able to do to reproduce is after we implement #897 we can try setting the X-Server-Timeout header to a very small value.

@plamut plamut changed the base branch from master to main August 26, 2021 10:43
@plamut
Copy link
Contributor

plamut commented Aug 26, 2021

Please just note that the target has been changed from master to main, i.e. the new primary branch.

@quentin-sommer
Copy link
Author

I'll try to reproduce it with #897 option 👍 @plamut Thanks for the heads-up

@tswast tswast closed this Aug 30, 2021
@tswast
Copy link
Contributor

tswast commented Aug 30, 2021

In internal issue 195337762, we did some testing with the X-Server-Timeout header and these were actually reported as "reason": "backendError". Without examples of where "reason": "timeout" appears, I don't think we should accept this PR.

From https://cloud.google.com/bigquery/docs/error-messages, the "timeout" reason happens when "The job timed out.", which to me if anything indicates this should be added to job retry options, but without an example I don't think we should do that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming inserts are not retried when a timeout occurs
3 participants