Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type hints to client #302

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rinarakaki
Copy link

@rinarakaki rinarakaki commented Oct 11, 2024

Enables googleapis/python-storage#1362.

I checked:

  • mypy -p google.cloud._helpers
  • mypy -p google.cloud.client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested a review from a team as a code owner October 11, 2024 10:50
Copy link

conventional-commit-lint-gcf bot commented Oct 11, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 11, 2024
@rinarakaki rinarakaki changed the title chore: add typing fix: add type hints to client Oct 12, 2024
@rinarakaki rinarakaki changed the title fix: add type hints to client chore: add type hints to client Oct 15, 2024
@rinarakaki rinarakaki changed the title chore: add type hints to client fix: add type hints to client Oct 15, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants