Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove _ClientFactoryMixin #305

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rinarakaki
Copy link

It's a private class and inherited only by Client class, so I simply implemented those methods for Client, removing the ambiguity of arguments *args and **kwargs.

This makes it way easier to add type hints later (#302).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested a review from a team as a code owner October 16, 2024 12:59
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 16, 2024
@rinarakaki rinarakaki changed the title Remove _ClientFactoryMixin feat: remove _ClientFactoryMixin Oct 16, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants