Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix streaming pull close test flakiness #361

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 1, 2021

Fixes #352.
Fixes #373.

This PR fixes unit test flakiness by waiting for the streaming pull manager shutdown thread to finish running before making any assertions.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner April 1, 2021 11:16
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
Copy link
Contributor

@jimfulton jimfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what flakiness this is fixing.

On my machine, the system test test_publish_large_messages still fails with a timeout on this branch. Maybe that's not what this PR is intended to address.

@plamut
Copy link
Contributor Author

plamut commented Apr 7, 2021

@jimfulton It fixes the flakiness in unit tests.

If a system test covering the same code is now flaky, too, we should investigate that as well, but it's a separate issue (that test depends on some assumption about how the backend works).

Edit: Created an issue to track that.

@jimfulton
Copy link
Contributor

@jimfulton It fixes the flakiness in unit tests.

If a system test covering the same code is now flaky, too, we should investigate that as well, but it's a separate issue (that test depends on some assumption about how the backend works).

Oops, OK. :)

@plamut plamut merged commit 9f451a1 into googleapis:master Apr 9, 2021
@plamut plamut deleted the iss-352 branch April 9, 2021 13:21
@plamut plamut changed the title chore: fix streaming pull close test flakiness test: fix streaming pull close test flakiness May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants