-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pass explicit credentials in all unit tests creating clients #369
Conversation
To allow unit tests to run without connecting to the google APIs.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, the tests now pass even if the GOOGLE_APPLICATION_CREDENTIALS env variable is unset.
Also thanks for removing the duplicate tests, they make no sense now that Python 2 does not have to be supported anymore and string literals are former unicode
instances.
The CLA still needs to be signed so that the bot gives the green light for that check. |
We have a bit of a DRY violation with Any reason not to make |
Yeah, I signed it. How long does it take to verify? |
Playing a devil's advocate - the code might modify that mock which could affect other tests using the same mock. It's probably not applicable here, though. :) Since |
+1 |
@jimfulton It's almost instant, but you need to ping the bot. ;)
Edit: Provided that the CLA signing is indeed complete, I honestly don't remember all the details (if any) anymore. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@googlebot I signed it!
@googlebot I signed it! |
@googlebot I signed it! |
@jimfulton I would guess that your CLA is associated with a different e-mail address than the one you used to sign the git commits. |
@kokoro: force-run |
@jimfulton The failed build is due to a flaky systest (#352, which @plamut has a fix ready for in #361). We could go ahead and get that PR reviewed and merged and then merge here. I you to decide to trigger another build here, add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The credentials fixture is nice, LGTM.
@tseaver I hear I have to be in a special group for |
@jimfulton Looks like Kokoro did run at 17:02Z, well after you added the label at 16:21Z. I have no clue why the bot didn't remove the label, though. |
@tseaver , I also pushed a commit. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@jimfulton Congratulations on your first accepted PR! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your contribution!
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #366 🦕