-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release PR on every change (instead of only changes that modify the changelog) #1459
Comments
This is also an issue for us. We would like to see every commit in the PR, regardless of the commit type. Here is the scenario:
This can be verified by checking out to release-please branch in your machine. My
Yet it should be:
|
This seems like a reasonable option to add. We would likely want to implement it as an option for the manifest like We intentionally implemented it to only push on changes to not overload our CI systems when we have many non-release-note-worthy commits. |
I'd love to see |
@chingor13 Makes sense not to overload the CI systems. I could also be something like Understand that's still a breaking change, but feels like a sensible default. |
Any progress on this? We have Renovate configured to auto-merge safe dependency updates, and would like these updates to be included in release PRs. Currently workaround is to set a custom Another option that would give more control might be something like update-types:
- feat
- fix
- chore Would be even more powerful if you could include scope: update-types:
- feat
- fix
- chore(deps) |
Fixes googleapis#1459 This patch adds a new option "always-update" that forces existing pull requests to be updated even when there are no changes to the release notes. This is useful, for example, when the repository enforces pull requests to be up-to-date with the main branch before they can be merged. Without this option set to `true`, that is, with the default behavior of release-please, if the last commit made to the main branch does not appear in the release notes, the existing pull request branch would not be rebased.
* feat: add "always-update" config option Fixes #1459 This patch adds a new option "always-update" that forces existing pull requests to be updated even when there are no changes to the release notes. This is useful, for example, when the repository enforces pull requests to be up-to-date with the main branch before they can be merged. Without this option set to `true`, that is, with the default behavior of release-please, if the last commit made to the main branch does not appear in the release notes, the existing pull request branch would not be rebased. * feat: apply suggested changes --------- Co-authored-by: Fabian Meyer <3982806+meyfa@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com>
Is your feature request related to a problem? Please describe.
We've been using release-please to manage our release and changelog. We've noticed that the release PR is only updated if the PR includes a commit with either
fix:
orfeat:
.Sometimes we have PRs that add tests or fix problems with our release workflows. We'd like to include those commits in the release branch, but we don't want them to be included in the changelog (because our users aren't interested in those changes).
I wasn't able to find any option to make this happen, so I'm assuming it's not possible right now.
Describe the solution you'd like
I'd like to be able to configure release-please so that all changes that go into main are included in the release PR, but only the categories that are "not hidden" are added to the changelog.
Either a top-level setting, or a new field in the
changelog-sections
would work fine for us.Describe alternatives you've considered
Not sure about any alternatives.
Thank you for your consideration!
The text was updated successfully, but these errors were encountered: