Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always-update #2420

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: always-update #2420

merged 4 commits into from
Nov 12, 2024

Conversation

zirkelc
Copy link
Contributor

@zirkelc zirkelc commented Nov 6, 2024

Copy of PR #2337 with applied changes

It looks like the original PR #2337 is stale with just a few changes to go. I'd like to help out and fix these changes to get this PR over the finish line. I hope the maintainers and @meyfa don't mind :-)

Please let me know if that's okay and if there are any other changes to consider.

Fixes #1459 🦕

BEGIN_COMMIT_OVERRIDE
feat: add always-update option to push to always push to release branch
END_COMMIT_OVERRIDE

meyfa and others added 4 commits July 14, 2024 15:00
Fixes googleapis#1459

This patch adds a new option "always-update" that forces existing pull
requests to be updated even when there are no changes to the
release notes. This is useful, for example, when the repository
enforces pull requests to be up-to-date with the main branch before
they can be merged. Without this option set to `true`, that is, with the
default behavior of release-please, if the last commit made to the
main branch does not appear in the release notes, the existing pull
request branch would not be rebased.
@zirkelc zirkelc requested review from a team as code owners November 6, 2024 14:45
Copy link

google-cla bot commented Nov 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 6, 2024
@chingor13 chingor13 changed the title feat: always-update (copy of #2337) feat: always-update Nov 12, 2024
@chingor13 chingor13 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into googleapis:main with commit 72d40df Nov 12, 2024
11 checks passed
@chingor13 chingor13 added the release-please:force-run To run release-please label Nov 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release PR on every change (instead of only changes that modify the changelog)
3 participants