-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-workspace): maintain current version range prefix #1723
Conversation
Hey, I have seen #1580 and saw a suggestion to maintain the current range prefix when doing a release. That would work for us in the Puppeteer project (currently, we rely on a custom script to pin dependencies that does not update the changelog). Let me know if you think this approach would make sense and I will look into improving test coverage (hints are welcome). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just about to start looking into #1580 again and noticed this PR 👍
You can copy the tests from #1580 and modify them slightly.
The current tests should fail anyway and also need probably fixing.
b9dcb35
to
c01eb07
Compare
c01eb07
to
46eb729
Compare
46eb729
to
8e0de8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: