fix: linked-versions + includeComponentInTag=false should work #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
fix-linked-versions
branch
from
60dcc6a
to
cbb0287
Compare
OrKoN
force-pushed
the
fix-linked-versions
branch
2 times, most recently
from
4e63633
to
7794238
Compare
OrKoN
force-pushed
the
fix-linked-versions
branch
from
7794238
to
8b06bcd
Compare
OrKoN
commented
Nov 17, 2022
docs/manifest-releaser.md
Outdated
| @@ -517,7 +517,7 @@ Example: | |||
| }, | |||
| { | |||
| "type": "linked-versions", | |||
| "group-name": "my group", | |||
| "groupName": "my group", | |||
There was a problem hiding this comment.
Drive-by doc update: as release-please actually accepts groupName and does not accept group-name
OrKoN
force-pushed
the
fix-linked-versions
branch
from
8b06bcd
to
840b8d5
Compare
|
@chingor13 Reviewer needed |
|
Any update on this? This is causing issues in my current project. |
|
Updates please |
nrodriguez-chub
added a commit
to nrodriguez-chub/release-please
that referenced
this pull request
Jan 31, 2024
…\n\n Continues this: googleapis#1749
4 tasks
nrodriguezmore
added a commit
to nrodriguezmore/release-please
that referenced
this pull request
Feb 1, 2024
…\n\n Continues this: googleapis#1749
nrodriguezmore
added a commit
to nrodriguezmore/release-please
that referenced
this pull request
Feb 1, 2024
…\n\n Continues this: googleapis#1749
nrodriguezmore
added a commit
to nrodriguezmore/release-please
that referenced
this pull request
Feb 1, 2024
…\n\n Continues this: googleapis#1749
nrodriguezmore
added a commit
to nrodriguezmore/release-please
that referenced
this pull request
Feb 1, 2024
…\n\n Continues this: googleapis#1749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1750 🦕