Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linked-versions plugin and includeComponentInTag=false don't work together #1750

Closed
OrKoN opened this issue Nov 14, 2022 · 0 comments · May be fixed by #1749
Closed

linked-versions plugin and includeComponentInTag=false don't work together #1750

OrKoN opened this issue Nov 14, 2022 · 0 comments · May be fixed by #1749
Assignees
@chingor13
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@OrKoN
Copy link
Contributor

OrKoN commented Nov 14, 2022

Environment details

  • OS: MacOS
  • Node.js version: v18.12.1
  • npm version: 8.19.2
  • release-please version: 14.17.0

Steps to reproduce

  1. Have a manifest file that combines includeComponentInTag=false and the linked-versions plugin (https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json#L19)
  2. Make a release

Expected: versions of the linked packages are force bumped to the same version.
Actual: the versions of the linked packages are different.

It happens because includeComponentInTag removes the component from the package not only for the publishing but also for the merge of PRs.

#1749 attempts fixing it but it regressed existing tests but I am not sure how to fix them yet.
@OrKoN OrKoN added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 14, 2022
@OrKoN OrKoN mentioned this issue Nov 17, 2022
Open
4 tasks
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 31, 2023
nekowinston added a commit to catppuccin/vscode that referenced this issue Jan 3, 2024
@nekowinston
ci(rp): fix linked-versions config bug
76ae05f 
refs: googleapis/release-please#1750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: linked-versions + includeComponentInTag=false should work OrKoN/release-please
3 participants
@chingor13 @OrKoN @SurferJeffAtGoogle