-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace:*
is updated to a specific version when working with pnpm workspace
#2173
workspace:*
is updated to a specific version when working with pnpm workspace
#2173
Comments
yes, it seems that previously lerna handled logic of "workspace:" versioning, now after moving to internal implementation of graph #2117 the only workspace handler left is that
any idea how to fix it? Rolling back to old version is not a great option since setup needs one of the "new" features upd. for now latest release-please version not affected by that issue is 16.2.0, my current solution is to use local installation of the package and run it in a pipeline. Not as nice as github action, but works. |
Any updates on this issue? We would like to migrate to v4 of release-please-action, which includes a couple fixes from release-please v16 that we've been waiting for, but our project makes use pnpm and |
Is there any workaround? |
Yarn workspaces are also affected. Release please keeps replacing Could someone explain how |
Submitted a PR with a fix. |
Could this please be released for release-please-action v4 as well? 🙏 It seems to still use 16.10.2 |
Hi! I'm using release-please in a pnpm workspace based monorepo throuth release-please-action to publish packages to a private registry.
It worked well on v3. But once I updated it to v4 I got an error due to `workspace:*`` was updated to a specific version.
I found that release-please-action bump release-please from 15.3 to 16.3 on v4, and the releated PRs are #2058 and #2117.
According to pnpm's documentation, it dynamically replace any
workspace:
dependency. So we don't need to update version of deps manually. And it is what v3 did.Of course, I can keep using v3, but I want to know if there is any other solution.
here is a repo to reproduce. https://github.com/YiCChi/front-monorepo
error log
The text was updated successfully, but these errors were encountered: