Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): do not update versions of packages installed using a protocol #2281

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(node): do not update versions of packages installed using a protocol #2281

merged 2 commits into from
Jun 6, 2024

Conversation

niieani
Copy link
Contributor

@niieani niieani commented May 4, 2024 •
edited
Loading

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2173 🦕

  • Fixes regression from 16.3.0 by omitting bumping any protocol-based dependencies.
  • Adds a test to make sure the regression doesn't happen again

@niieani niieani requested review from a team as code owners May 4, 2024 20:33
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 4, 2024
@niieani niieani mentioned this pull request May 4, 2024
Closed
@edgarkhanzadian edgarkhanzadian mentioned this pull request May 8, 2024
Merged
@kyranjamie
Copy link

Release this please 🙃

@kyranjamie
Copy link

Release this please 🙃 jhgjh

@edgarkhanzadian edgarkhanzadian mentioned this pull request May 17, 2024
Open
@chingor13 chingor13 merged commit eeb1411 into googleapis:main Jun 6, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Jun 6, 2024
Merged
@niieani niieani deleted the fix-non-version-bumps branch June 8, 2024 01:37
@stipsan stipsan mentioned this pull request Aug 7, 2024
Merged
@WontonSam WontonSam mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LZZLF LZZLF LZZLF approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace:* is updated to a specific version when working with pnpm workspace
4 participants
@niieani @kyranjamie @chingor13 @LZZLF